Last modified: 2014-10-21 12:56:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73545, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 71545 - Argument 1 passed to AbuseFilter::contentToString() must implement interface Content
Argument 1 passed to AbuseFilter::contentToString() must implement interface ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
u=dev c=backend p=0
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-02 06:35 UTC by Aude
Modified: 2014-10-21 12:56 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Aude 2014-10-02 06:35:52 UTC 
Catchable fatal error: Argument 1 passed to AbuseFilter::contentToString() must implement interface Content, null given, called in /srv/mediawiki/php-1.25wmf1/extensions/AbuseFilter/AbuseFilter.hooks.php on line 154 and defined at /srv/mediawiki/php-1.25wmf1/extensions/AbuseFilter/AbuseFilter.class.php on line 2297

Backtrace:
#0 /srv/mediawiki/php-1.25wmf1/extensions/AbuseFilter/AbuseFilter.class.php(2297): AbuseFilter::contentToString()
#1 /srv/mediawiki/php-1.25wmf1/extensions/AbuseFilter/AbuseFilter.hooks.php(154): AbuseFilter::contentToString(NULL)
#2 /srv/mediawiki/php-1.25wmf1/extensions/AbuseFilter/AbuseFilter.hooks.php(106): AbuseFilterHooks::filterEdit(Object(DerivativeContext), Object(Wikibase\ItemContent), 'Q15397877?Disch...', Object(Status), '/* wbeditentity...', false)
#3 [internal function]: AbuseFilterHooks::onEditFilterMergedContent(Object(DerivativeContext), Object(Wikibase\ItemContent), Object(Status), '/* wbeditentity...', Object(User), false)
#4 /srv/mediawiki/php-1.25wmf1/includes/Hooks.php(206): call_user_func_array('AbuseFilterHook...', Array)
#5 /srv/mediawiki/php-1.25wmf1/includes/GlobalFunctions.php(3991): Hooks::run('EditFilterMerge...', Array, NULL)
#6 /srv/mediawiki/php-1.25wmf1/extensions/Wikidata/extensions/Wikibase/repo/includes/EditEntity.php(778): wfRunHooks('EditFilterMerge...', Array)
#7 /srv/mediawiki/php-1.25wmf1/extensions/Wikidata/extensions/Wikibase/repo/includes/EditEntity.php(704): Wikibase\EditEntity->runEditFilterHooks('/* wbeditentity...')
#8 /srv/mediawiki/php-1.25wmf1/extensions/Wikidata/extensions/Wikibase/repo/includes/api/ApiWikibase.php(446): Wikibase\EditEntity->attemptSave('/* wbeditentity...', 18, '0b9fa35041cf3d1...')
#9 /srv/mediawiki/php-1.25wmf1/extensions/Wikidata/extensions/Wikibase/repo/includes/api/ModifyEntity.php(371): Wikibase\Api\ApiWikibase->attemptSaveEntity(Object(Wikibase\DataModel\Entity\Item), Object(Wikibase\Summary), 18)
#10 /srv/mediawiki/php-1.25wmf1/includes/api/ApiMain.php(932): Wikibase\Api\ModifyEntity->execute()
#11 /srv/mediawiki/php-1.25wmf1/includes/api/ApiMain.php(364): ApiMain->executeAction()
#12 /srv/mediawiki/php-1.25wmf1/includes/api/ApiMain.php(335): ApiMain->executeActionWithErrorHandling()
#13 /srv/mediawiki/php-1.25wmf1/api.php(85): ApiMain->execute()
#14 /srv/mediawiki/w/api.php(3): require('/srv/mediawiki/...')
Comment 1 Marius Hoch 2014-10-13 19:59:27 UTC 
This actually is an AbuseFilter bug where AbuseFilter chokes on Revision::getContent returning null
Comment 2 Gerrit Notification Bot 2014-10-13 20:07:53 UTC 
Change 166510 had a related patch set uploaded by Hoo man:
Check for Revision::getContent returning null

https://gerrit.wikimedia.org/r/166510
Comment 3 Gerrit Notification Bot 2014-10-14 00:50:44 UTC 
Change 166522 had a related patch set uploaded by Jackmcbarn:
Remove negative caching from Revision::getContentInternal

https://gerrit.wikimedia.org/r/166522
Comment 4 Gerrit Notification Bot 2014-10-21 12:52:45 UTC 
Change 166510 abandoned by Hoo man:
Check for Revision::getContent returning null

Reason:
Core change merged instead (https://gerrit.wikimedia.org/r/166522). Let's hope that fixes the issue

https://gerrit.wikimedia.org/r/166510
Comment 5 Marius Hoch 2014-10-21 12:53:35 UTC 
Core patch approved, so that we no longer should see such revisions.
Comment 6 Gerrit Notification Bot 2014-10-21 12:56:06 UTC 
Change 166522 merged by jenkins-bot:
Remove negative caching from Revision::getContentInternal

https://gerrit.wikimedia.org/r/166522
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links