Last modified: 2014-10-16 23:45:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73580, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 71580 - VisualEditor: [Regression wmf2] Deleting any focusable node throws "error:NS_ERROR_FAILURE:" in Firefox and wrong context menu starts appearing for other nodes
VisualEditor: [Regression wmf2] Deleting any focusable node throws "error:NS_...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Highest major
: VE-deploy-2014-10-09
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-02 23:03 UTC by Rummana Yasmeen
Modified: 2014-10-16 23:45 UTC (History)
6 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Screenshot (98.00 KB, image/png)
2014-10-02 23:03 UTC, Rummana Yasmeen 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-10-02 23:03:18 UTC 
Created attachment 16653 [details]
Screenshot

Steps to reproduce:

1.Open a page with VE
2.Select any focusable node: citation note,math ,template or image

Observed Result:

The following error appears in the console:
NS_ERROR_FAILURE: 

The context menu for that focusable note is still active in CE ,if you select some other focusable note after this, no context menu appears for it or the one for previous node appears on top of it

Environment:test2 and Betalabs
Comment 1 Bartosz Dziewoński 2014-10-03 13:15:00 UTC 
Reproducible in standalone with comment nodes too.
Comment 2 Bartosz Dziewoński 2014-10-03 13:25:24 UTC 
Caused by 0d7eaf51767c4061b478610a035a3bc387c0973a (workaround for bug 70724 about broken Firefox cursoring). Calling .collapseToStart() sometimes fixes the selection, and sometimes causes this cryptic exception.

This looks very ugly and very internal, so I'm just going to revert the patch and update the upstream bug report.
Comment 3 Gerrit Notification Bot 2014-10-03 13:26:34 UTC 
Change 164548 had a related patch set uploaded by Bartosz Dziewoński:
Revert "ve.ce.Surface: Magic workaround for broken Firefox cursoring"

https://gerrit.wikimedia.org/r/164548
Comment 4 Gerrit Notification Bot 2014-10-03 17:53:16 UTC 
Change 164593 had a related patch set uploaded by Jforrester:
Revert "ve.ce.Surface: Magic workaround for broken Firefox cursoring"

https://gerrit.wikimedia.org/r/164593
Comment 5 Gerrit Notification Bot 2014-10-03 17:53:51 UTC 
Change 164548 merged by jenkins-bot:
Revert "ve.ce.Surface: Magic workaround for broken Firefox cursoring"

https://gerrit.wikimedia.org/r/164548
Comment 6 Gerrit Notification Bot 2014-10-03 17:55:25 UTC 
Change 164593 merged by jenkins-bot:
Revert "ve.ce.Surface: Magic workaround for broken Firefox cursoring"

https://gerrit.wikimedia.org/r/164593
Comment 7 Rummana Yasmeen 2014-10-07 19:00:06 UTC 
Verified the fix in Betalabs
Comment 8 Rummana Yasmeen 2014-10-08 21:56:02 UTC 
Verified the backport in test2
Comment 9 Rummana Yasmeen 2014-10-16 23:45:36 UTC 
Verified the fix in production
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links