Last modified: 2014-10-04 19:54:26 UTC
[regression] [[mediawiki:sidebar]] no longer supports entirely numeric headers ("* 3829") don't have to be logged in to see the error. stack (below) varies depending on the skin in use. (broken with both monobook and vector) probably broke sometime between 2014-08-10 (last revision before it was noticed broken @ wikimaniateam) and 2014-10-03. lego says the bug is in Skin::addToSidebarPlain see also https://stackoverflow.com/questions/4100488/a-numeric-string-as-array-key-in-php Unexpected non-MediaWiki exception encountered, of type "InvalidArgumentException" [16b391a6] /wiki/Main_Page?useskin=monobook Exception from line 240 of /srv/mediawiki/php-1.25wmf2/includes/Message.php: $key must be a string or an array Backtrace: #0 /srv/mediawiki/php-1.25wmf2/includes/GlobalFunctions.php(1424): Message->__construct(integer, array) #1 /srv/mediawiki/php-1.25wmf2/skins/MonoBook/MonoBookTemplate.php(352): wfMessage(integer) #2 /srv/mediawiki/php-1.25wmf2/skins/MonoBook/MonoBookTemplate.php(220): MonoBookTemplate->customBox(integer, array) #3 /srv/mediawiki/php-1.25wmf2/skins/MonoBook/MonoBookTemplate.php(136): MonoBookTemplate->renderPortals(array) #4 /srv/mediawiki/php-1.25wmf2/includes/skins/SkinTemplate.php(242): MonoBookTemplate->execute() #5 /srv/mediawiki/php-1.25wmf2/includes/OutputPage.php(2186): SkinTemplate->outputPage() #6 /srv/mediawiki/php-1.25wmf2/includes/MediaWiki.php(594): OutputPage->output() #7 /srv/mediawiki/php-1.25wmf2/includes/MediaWiki.php(435): MediaWiki->main() #8 /srv/mediawiki/php-1.25wmf2/index.php(46): MediaWiki->run() #9 /srv/mediawiki/w/index.php(3): include(string) #10 {main}
Most likely caused by I458c0af3114754ddf3d721f6c374e249f482e4cf. The bug is that if you set a string which is also an integer to the key of an array, PHP will cast it to an int, and then we try passing it to wfMessage, which throws an error. In MonoBookTemplate::customBox we should cast the keys to strings before passing to wfMessage.
Setting milestone to 1.24.0 release.
