Last modified: 2014-10-18 13:26:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73652, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 71652 - VisualEditor: MWLink nodes inside sub-editor dialogs appear as zero-width
VisualEditor: MWLink nodes inside sub-editor dialogs appear as zero-width
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-10-16
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-05 00:48 UTC by James Forrester
Modified: 2014-10-18 13:26 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2014-10-05 00:48:35 UTC 
* Insert a reference (Cite > Basic)
* Insert an MWLink node (Ctrl + K > http://www.amazon.com)

Observe magic zero-width node. Converting to an annotation makes it work fine.

Same happens in media caption dialogs.
Comment 1 Roan Kattouw 2014-10-05 07:55:21 UTC 
This is because the CSS for these link nodes (and pretty much everything else from Parsoid CSS) is scoped to .mw-body-content, a class that we set on the main ce.Surface but not on surfaces inside of dialogs.

I tried applying mw-body-content to the surface in the dialog, and that does cause the link node to appear, but it also messes up the font size. Someone with a better understanding of our various layers of font size manipulation (coughtrevorcough) should look at this.
Comment 2 Gerrit Notification Bot 2014-10-15 23:57:00 UTC 
Change 166918 had a related patch set uploaded by Trevor Parscal:
Apply mw-body-content styles to SurfaceWidget

https://gerrit.wikimedia.org/r/166918
Comment 3 Gerrit Notification Bot 2014-10-16 00:42:27 UTC 
Change 166918 merged by jenkins-bot:
Apply mw-body-content styles to SurfaceWidget

https://gerrit.wikimedia.org/r/166918
Comment 4 etonkovidova 2014-10-17 20:19:05 UTC 
Verified the fix on test2.
Comment 5 Gerrit Notification Bot 2014-10-17 22:54:52 UTC 
Change 167335 had a related patch set uploaded by Jforrester:
Apply mw-body-content styles to SurfaceWidget

https://gerrit.wikimedia.org/r/167335
Comment 6 Gerrit Notification Bot 2014-10-17 23:19:09 UTC 
Change 167335 merged by jenkins-bot:
Apply mw-body-content styles to SurfaceWidget

https://gerrit.wikimedia.org/r/167335
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links