Last modified: 2014-10-23 16:56:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73675, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71675 - "Preview with PediaPress" defunct
"Preview with PediaPress" defunct
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Collection (Other open bugs)
unspecified
All All
: High normal (vote)
: MW 1.24 version
Assigned To: C. Scott Ananian
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-05 18:32 UTC by Christoph Kepper
Modified: 2014-10-23 16:56 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Christoph Kepper 2014-10-05 18:32:53 UTC
A click on "Preview with PediaPress" on https://en.wikipedia.org/wiki/Special:Book always leads to the following error message:

Book rendering failed
There was an error while attempting to render your book.
Return to Main Page.

Bug also confirmed on de.wikipedia.org and es.wikipedia.org.
Comment 1 Marcin Cieślak 2014-10-06 22:32:46 UTC
Confirmed on plwiki as well.

But MediaWiki at fd9173e with extension Collection also at its git master installed locally do work (4b4bc6c05883ff2d8061d88bd5e7b861725a16ba); one gets redirected to the PediaPress website.
Comment 2 C. Scott Ananian 2014-10-07 15:51:54 UTC
It appears that the 'zip_post' command is going to the OCG servers (who can't handle it) instead of the public pediapress servers.
Comment 3 Nemo 2014-10-07 16:08:06 UTC
(In reply to Marcin Cieślak from comment #1)
> Confirmed on plwiki as well.
> 
> But MediaWiki at fd9173e with extension Collection also at its git master
> installed locally do work (4b4bc6c05883ff2d8061d88bd5e7b861725a16ba); one
> gets redirected to the PediaPress website.

If OCG is not configured at all, you mean? It's conceivable that some (few?) REL1_24 users will set up OCG, so I'd rather have the fix in REL1_24 as well.
Comment 4 Gerrit Notification Bot 2014-10-07 16:20:23 UTC
Change 165234 had a related patch set uploaded by Cscott:
Allow overriding the default server for POD functions.

https://gerrit.wikimedia.org/r/165234
Comment 5 Gerrit Notification Bot 2014-10-07 16:29:48 UTC
Change 165239 had a related patch set uploaded by Cscott:
Disable PediaPress POD function.

https://gerrit.wikimedia.org/r/165239
Comment 6 C. Scott Ananian 2014-10-07 16:34:10 UTC
The PediaPress link should be re-added to [[:en:Template:Saved_book]] once this function works again.
Comment 7 Gerrit Notification Bot 2014-10-07 16:50:43 UTC
Change 165234 merged by jenkins-bot:
Allow overriding the default server for POD functions.

https://gerrit.wikimedia.org/r/165234
Comment 8 Gerrit Notification Bot 2014-10-07 19:09:18 UTC
Change 165239 merged by jenkins-bot:
Disable PediaPress POD function.

https://gerrit.wikimedia.org/r/165239
Comment 9 Christoph Kepper 2014-10-08 07:56:57 UTC
Well - turning the book export off completely prevents the error message from popping up, but it also does not make anything better. Our customers are complaining that they cannot export their books. 
Was there a problem with using tools.pediapress.com?
Comment 10 C. Scott Ananian 2014-10-08 19:05:04 UTC
Yes, tools.pediapress.com is giving "Server returned error: system overloaded. please try again later." errors when I test it locally.

But we need to land/deploy https://gerrit.wikimedia.org/r/165234 before we can redirect post_zip requests to tools.pediapress.com.  Hopefully once that lands you'll have tools.pediapress.com ready to handle the load and we can turn the POD function back on.

Note that Gerrit change #165234 pushes the post_zip requests over to tools.pediapress.com.  The OCG bundle format is largely compatible, but there's no code written to take OCG zip bundles and post them to pediapress.  So pediapress needs to be rolling the zip bundles itself.
Comment 11 C. Scott Ananian 2014-10-08 19:06:36 UTC
Oh, and Christoph: feel free to jump into #wikimedia-tech on freenode today (2014-10-08) or #mediawiki-parsoid any time to discuss the technical details; my IRC nick is 'cscott'.
Comment 12 Erik Moeller 2014-10-21 02:00:27 UTC
That changeset landed on WP last week, yes? If so, how are things on the PP side of things - can we re-enable soon? We're still expecting to phase this out eventually, but for now it'd be nice to have it back :-)
Comment 13 Christoph Kepper 2014-10-21 05:19:54 UTC
Hi Erik, I talked to Nemo and CScott last week during the bug triage. As you can see above the PediaPress public toolserver could not handle the load from Wikipedia post requests and so CScott decided to turn it off.. 

In the meantime we set up another endpoint specifically for Wikimedia. CScott wanted to test the new endpoint and re-enable PediaPress afterwards. As we are getting quite a few complaints from would-be customers right now, we would also like to have it back ;-)
Comment 14 C. Scott Ananian 2014-10-21 14:00:46 UTC
Yup.  I was on vacation last week, but I'm back now.  I'll try to test this new endpoint out today.
Comment 15 Gerrit Notification Bot 2014-10-21 14:10:30 UTC
Change 167806 had a related patch set uploaded by Cscott:
Update PediaPress endpoint; re-enable PediaPress in labs for testing.

https://gerrit.wikimedia.org/r/167806
Comment 16 C. Scott Ananian 2014-10-21 17:45:26 UTC
Queued the above patch for deploy to beta (ie, http://en.wikipedia.beta.wmflabs.org/ ) on 22 October: https://wikitech.wikimedia.org/wiki/Deployments#Wednesday.2C.C2.A0October.C2.A022
Comment 17 Gerrit Notification Bot 2014-10-21 18:11:24 UTC
Change 167806 merged by jenkins-bot:
Update PediaPress endpoint; re-enable PediaPress in labs for testing.

https://gerrit.wikimedia.org/r/167806
Comment 18 C. Scott Ananian 2014-10-21 18:48:16 UTC
This was deployed early, it's live on beta now.
Comment 19 C. Scott Ananian 2014-10-21 18:54:31 UTC
Initial testing looks good.  Christoph, could you give it a try on http://en.wikipedia.beta.wmflabs.org/ before I turn it on in production?
Comment 20 Gerrit Notification Bot 2014-10-21 18:58:54 UTC
Change 167866 had a related patch set uploaded by Cscott:
Re-enable PediaPress POD in production.

https://gerrit.wikimedia.org/r/167866
Comment 21 Christoph Kepper 2014-10-21 19:32:39 UTC
Thank you very much Scott. I checked the upload and the preview. Looks good to me :-)
Comment 22 C. Scott Ananian 2014-10-21 19:35:40 UTC
Ok.  I've scheduled the patch to turn this on in production for the same Wednesday morning window.
Comment 23 Gerrit Notification Bot 2014-10-22 15:03:41 UTC
Change 167866 merged by jenkins-bot:
Re-enable PediaPress POD in production.

https://gerrit.wikimedia.org/r/167866
Comment 24 C. Scott Ananian 2014-10-22 15:16:35 UTC
So we've deployed the patch and turned it on, but I'm getting a "Book rendering failed: There was an error while attempting to render your book." when I try to use PediaPress on enwiki.  Rendering to PediaPress on beta still seems to work fine.

PediaPress folks: can you take a look at the logs on your side and see if you're getting what you expect?
Comment 25 Christoph Kepper 2014-10-22 15:17:51 UTC
OK - I will try to figure out what is going on.
Comment 26 Gerrit Notification Bot 2014-10-22 15:52:45 UTC
Change 168091 had a related patch set uploaded by Cscott:
Send Extension:Collection logs to logstash.

https://gerrit.wikimedia.org/r/168091
Comment 27 Gerrit Notification Bot 2014-10-22 15:55:54 UTC
Change 168091 merged by jenkins-bot:
Send Extension:Collection logs to logstash.

https://gerrit.wikimedia.org/r/168091
Comment 28 C. Scott Ananian 2014-10-22 16:20:01 UTC
Looks like outgoing connections are firewalled on the WMF side (well, not firewalled exactly, more like "not routed from our VLAN").  It works from beta because the labs environment is open.

We can use WMF's url-downloader proxy to work around this, but I need to right a patch to allow Extension:Collection to use a proxy when making its requests.

marktraceur: we can either SWAT the revert patch ( https://gerrit.wikimedia.org/r/168082 ) and then wait for the patch to Collection to ride the usual deploy train before trying again, or else we can SWAT the new patch for Collection and a tweak to the mediawiki config later today.
Comment 29 Gerrit Notification Bot 2014-10-22 17:34:53 UTC
Change 168114 had a related patch set uploaded by Cscott:
Use url-downloader proxy to reach PediaPress POD service.

https://gerrit.wikimedia.org/r/168114
Comment 30 Gerrit Notification Bot 2014-10-22 17:36:48 UTC
Change 168082 had a related patch set uploaded by Cscott:
Revert "Re-enable PediaPress POD in production."

https://gerrit.wikimedia.org/r/168082
Comment 31 Gerrit Notification Bot 2014-10-22 23:23:12 UTC
Change 168114 merged by jenkins-bot:
Use url-downloader proxy to reach PediaPress POD service.

https://gerrit.wikimedia.org/r/168114
Comment 32 C. Scott Ananian 2014-10-22 23:28:11 UTC
Ok, new patch using url-downloader to proxy out to pediapress is deployed.

Please test.  Seems like it works to me!
Comment 33 Gerrit Notification Bot 2014-10-23 03:13:14 UTC
Change 168082 abandoned by Cscott:
Revert "Re-enable PediaPress POD in production."

Reason:
Abandoned in favor of https://gerrit.wikimedia.org/r/168114

https://gerrit.wikimedia.org/r/168082
Comment 34 Erik Moeller 2014-10-23 16:56:09 UTC
<3 Thanks for fixing this so quickly! :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links