Last modified: 2014-11-01 01:41:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73701, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71701 - Cannot save deletion of {{clarify span}} template
Cannot save deletion of {{clarify span}} template
Status: NEW
Product: VisualEditor
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on: 72191
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-06 11:26 UTC by Spinningspark
Modified: 2014-11-01 01:41 UTC (History)
5 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Spinningspark 2014-10-06 11:26:45 UTC
Intention:
Remove a template on en.wikipedia.  The template in question is {{clarify span}}

Steps to Reproduce:
1. Click on span to open the template dialogue
2. Click on show options
3. Click on the delete icon next to the template name

Actual Results:  
The transclusion dialogue then goes blank.  The "Apply changes" button is greyed out so the edit cannot be saved.  The cancel button is still live, but this results in the edit not being saved.

This is possibly an issue with other templates as well - I haven't tried.

Expected Results:  
The template transclusion should be replaced by the contents of field 1.

Reproducible: Didn't try

This edit https://en.wikipedia.org/w/index.php?title=Frame-dragging&diff=next&oldid=628355567 had to be done by manually retyping the passage.  It could not be done through the template dialogue.  Not such a burden in this particular case as the passage was short, but the template is capable of containing a much lengthier block of text.
Comment 1 Elitre 2014-10-06 11:38:54 UTC
To remove a template, you simply click on it and press Canc or Backspace.
Comment 2 Spinningspark 2014-10-06 12:19:42 UTC
(In reply to Elitre from comment #1)
> To remove a template, you simply click on it and press Canc or Backspace.

Yes, but that also removes the text the template was bracketing.  The text needs to be retained.  Besides which, if the "delete template" button from within the dialogue is non-functional, that is still a bug.
Comment 3 Elitre 2014-10-06 13:24:43 UTC
I believe that ATM the fastest way to do so is simply copying the text, removing the template, pasting the text? A better support of templates incapsulating text has already been requested elsewhere, although I'm afraid I can't provide a link right now.
I also believe that that advanced settings interface is probably working as intended; the function is there to allow you to replace a template with another one (having to click like 5 times simply to get rid of a template would be such a bad experience!). James will tell us more, anyway :)
Comment 4 Spinningspark 2014-10-06 16:40:13 UTC
It's quite difficult to select the text without opening the template.  Having opened it, it is not five clicks to get to delete.  Having selected delete, it makes no sense not to allow "save changes" without specifying a replacement template.
Comment 5 Bartosz Dziewoński 2014-10-06 16:52:41 UTC
Right, there are actually two issues here:

* It's not possible to "Apply changes" from the transclusion dialog after it
  has been emptied. This is obviously a bug and should be easy to fix.

* You're requesting support for "annotation templates", as I've heard it
  called during some brainstorming – a way to apply some styling or data from
  a template to some text, similarly to how you can mark text as bold, italic
  or being a link. I don't think there's a feature request filed for it, but
  it has been thought about.
  
  Possibly interesting are bug 54186, which is actually the inverse of this
  (rather than removing a template from text, it asks for a way to apply a
  template on top of text), or bug 18231 which asks for a way to annotate
  which fragment of text a citation pertains to.
Comment 6 Spinningspark 2014-10-06 17:16:53 UTC
Agreed there are two issues here, and I'm happy for this to be split into two bugs if necessary.  It must also be easy to add a "save as plain text" button or something similar.  If this *has* to be done with a template, it could be done with a subst'd template that outputs just field 1.  Ooooh, just noticed the template form doesn't have a tick box for "subst", that's going to be needed one day.
Comment 7 Bartosz Dziewoński 2014-10-06 17:46:02 UTC
(In reply to Spinningspark from comment #6)
> Ooooh, just noticed the template form doesn't have a tick box for "subst",
> that's going to be needed one day.

Bug 49904.
Comment 8 Alex Monk 2014-11-01 01:41:47 UTC
(In reply to Bartosz Dziewoński from comment #5)
> * It's not possible to "Apply changes" from the transclusion dialog after it
>   has been emptied. This is obviously a bug and should be easy to fix.

Bug 72191.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links