Last modified: 2014-10-15 13:37:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73714, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 71714 - JSHint: Clean up .jshintignore
JSHint: Clean up .jshintignore
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
Hygiene (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Jon
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-06 19:04 UTC by Jon
Modified: 2014-10-15 13:37 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2014-10-06 19:04:14 UTC 
In JSHint we allow
		"strictEqual": true,
		"deepEqual": true,
		"ok": true,

We should remove these and fix the tests that make use of them. We shouldn't use globals for things that are not libraries.

Note mwMobileFrontendConfig can also be removed.
Comment 1 Gerrit Notification Bot 2014-10-07 20:46:33 UTC 
Change 165346 had a related patch set uploaded by Jdlrobson:
WIP: Cleanup jshintrc

https://gerrit.wikimedia.org/r/165346
Comment 2 Gerrit Notification Bot 2014-10-07 21:35:04 UTC 
Change 165369 had a related patch set uploaded by Jdlrobson:
Hygiene: Refactor tests / jshintrc to not use globals

https://gerrit.wikimedia.org/r/165369
Comment 3 Gerrit Notification Bot 2014-10-07 21:35:55 UTC 
Change 165346 abandoned by Jdlrobson:
WIP: Cleanup jshintrc

https://gerrit.wikimedia.org/r/165346
Comment 4 Gerrit Notification Bot 2014-10-15 13:36:26 UTC 
Change 165369 merged by jenkins-bot:
Hygiene: Refactor tests / jshintrc to not use globals

https://gerrit.wikimedia.org/r/165369
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links