Last modified: 2014-10-08 21:21:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73749, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 71749 - Globalization on login not rechecking ownership of homewiki leads to adding unowned accounts to the global account


Summary:	Globalization on login not rechecking ownership of homewiki leads to adding u...

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	CentralAuth (Other open bugs)
Version:	master
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Kunal Mehta (Legoktm)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-10-07 17:22 UTC by Chris Steipp
Modified:	2014-10-08 21:21 UTC (History)
CC List:	6 users (show)

See Also:	70468
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
patch (1.27 KB, patch) 2014-10-07 17:41 UTC, Kunal Mehta (Legoktm)	Details
script to break up bad global accounts (5.20 KB, text/plain) 2014-10-08 16:54 UTC, Kunal Mehta (Legoktm)	Details
Patch after file reorg (1.30 KB, patch) 2014-10-08 21:03 UTC, Chris Steipp	Details
Add an attachment (proposed patch, testcase, etc.)

Description Chris Steipp 2014-10-07 17:22:39 UTC

Another case with the root of bug 70468. The fix should be the same as we did for the web interface-- pass $checkHome = true to the merge function.

Comment 1 Kunal Mehta (Legoktm) 2014-10-07 17:41:07 UTC

Created attachment 16693 [details]
patch

Patch made against 1.25wmf1, assumes that the patch for bug 70468 was also deployed. Cherry-picks cleanly against 1.25wmf2.

Comment 2 Chris Steipp 2014-10-07 18:28:40 UTC

I think that fixes the issue. Let's deploy it.

Comment 3 Kunal Mehta (Legoktm) 2014-10-08 16:54:15 UTC

Created attachment 16709 [details]
script to break up bad global accounts

Script that goes through the log files which I copied to terbium from fluorine, figures out if the user had a homewiki picked that was different from the current one, and then deletes the localuser/globaluser rows, and invalidates the CA cache, and local wiki caches.

Has a dry run mode, manually set the 'simulate' member variable to false to make it run.

Comment 4 Kunal Mehta (Legoktm) 2014-10-08 16:58:01 UTC

My dry-runs indicate that 581 global accounts will be broken up, which includes 4309 local accounts.

Comment 5 Chris Steipp 2014-10-08 21:03:34 UTC

Created attachment 16726 [details]
Patch after file reorg

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links