Last modified: 2014-10-17 17:26:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73750, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71750 - Checkboxes do not work in Firefox OS (Special:MobileOptions)
Checkboxes do not work in Firefox OS (Special:MobileOptions)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
MediaWiki UI (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 72189 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-07 17:23 UTC by Jon
Modified: 2014-10-17 17:26 UTC (History)
14 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Overlap (51.13 KB, image/png)
2014-10-07 17:23 UTC, Jon
Details

Description Jon 2014-10-07 17:23:47 UTC
Created attachment 16692 [details]
Overlap

Visiting Special:MobileOptions on a Firefox OS device you'll notice that the labels overlap the checkboxes.

The issue seems to be because the width does not apply to the invisible (opacity:0) input[type=checkbox] and as a result it doesn't make enough room for the pseudo element.

Confirmed in the Firefox OS developer preview phone we have in the office.
See also: https://bugzilla.mozilla.org/show_bug.cgi?id=1078393
Comment 1 Bingle 2014-10-07 17:25:17 UTC
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/K1RV5y2Z
Comment 2 Mike Taylor 2014-10-08 16:21:06 UTC
Hi! I wrote a blog post about this issue at https://miketaylr.com/posts/2014/10/max-width-in-firefox-mobile-browser-checkboxes.html. It seems like override the UA stylesheet's max-width should be enough to solve the problem for Firefox OS and Firefox for Android users.
Comment 3 Gerrit Notification Bot 2014-10-08 18:20:03 UTC
Change 165530 had a related patch set uploaded by Jdlrobson:
Optimise checkboxes for Firefox mobile

https://gerrit.wikimedia.org/r/165530
Comment 4 Jon 2014-10-08 18:22:57 UTC
Thanks for the write up Mike! I've written a patch our end ^ to work around the problem in the meantime.

Let me know if we can help Mozilla out in future with any other wiki related bugs!
Comment 5 Gerrit Notification Bot 2014-10-09 22:37:57 UTC
Change 165530 merged by jenkins-bot:
Optimise checkboxes for Firefox mobile

https://gerrit.wikimedia.org/r/165530
Comment 6 Jon 2014-10-17 16:44:21 UTC
*** Bug 72189 has been marked as a duplicate of this bug. ***
Comment 7 Amir E. Aharoni 2014-10-17 16:46:25 UTC
Thanks for the fix, Jon!

In such cases I always wonder which HTML engine has The Right Standard Behavior...
Comment 8 Mike Taylor 2014-10-17 17:04:38 UTC
:) In this case, I think it we were in the wrong. 

I landed the following patches for Firefox for Android and Firefox OS, so future versions won't need this workaround:

https://hg.mozilla.org/mozilla-central/rev/2316f7e0b196
https://hg.mozilla.org/mozilla-central/rev/9cdce80d5092
Comment 9 Amir E. Aharoni 2014-10-17 17:26:06 UTC
Awesome! Thank you very much. I love little collaborations of this kind :)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links