Last modified: 2014-11-16 12:32:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73768, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 71768 - UploadWizard should not register ResourceLoaderFileModule objects
UploadWizard should not register ResourceLoaderFileModule objects
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-07 23:09 UTC by Kunal Mehta (Legoktm)
Modified: 2014-11-16 12:32 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Kunal Mehta (Legoktm) 2014-10-07 23:09:09 UTC 
In UploadWizardHooks::resourceLoaderRegisterModules(), the modules are registered with an object. They should instead just be registered with the definition array, and let RL convert them to objects whenever needed.
Comment 1 Gerrit Notification Bot 2014-10-11 18:12:26 UTC 
Change 166202 had a related patch set uploaded by Legoktm:
Don't register ResourceLoaderFileModule objects

https://gerrit.wikimedia.org/r/166202
Comment 2 Gerrit Notification Bot 2014-10-13 13:03:26 UTC 
Change 166202 merged by jenkins-bot:
Don't register ResourceLoaderFileModule objects

https://gerrit.wikimedia.org/r/166202
Comment 3 Andre Klapper 2014-11-15 12:16:38 UTC 
All patches mentioned in this report were merged - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links