Last modified: 2014-11-03 21:51:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73769, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71769 - Unable to add new custom messages to validErrorMessages
Unable to add new custom messages to validErrorMessages
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-07 23:15 UTC by Jon
Modified: 2014-11-03 21:51 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Jon 2014-10-07 23:15:09 UTC
LoginForm::$validErrorMessages restricts the number of valid error messages. For a custom special page which requires login e.g. Special:Uploads (on mobile) we would like to display a custom message.

Should we add a hook or is there a nicer way extensions can register new messages?
Comment 1 Florian 2014-10-08 15:34:12 UTC
Another way i was thinking about is to add a new config variable storing an array with additional valid messages. This would need a little rewrite of the currently used access to the static var (LoginForm::$validErrorMessages). The negative point: Extensions still need to set thier messages very early in the setup process.
Comment 2 Gerrit Notification Bot 2014-11-01 16:10:59 UTC
Change 170520 had a related patch set uploaded by Florianschmidtwelzow:
UserLogin: Allow extensions to add valid error messages

https://gerrit.wikimedia.org/r/170520
Comment 3 Gerrit Notification Bot 2014-11-03 17:51:26 UTC
Change 170521 had a related patch set uploaded by Jdlrobson:
Use Hook to add valid error messages

https://gerrit.wikimedia.org/r/170521
Comment 4 Gerrit Notification Bot 2014-11-03 20:34:50 UTC
Change 170520 merged by jenkins-bot:
UserLogin: Allow extensions to add valid error messages

https://gerrit.wikimedia.org/r/170520
Comment 5 Gerrit Notification Bot 2014-11-03 21:51:19 UTC
Change 170521 merged by jenkins-bot:
Use Hook to add valid error messages

https://gerrit.wikimedia.org/r/170521

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links