Last modified: 2014-11-18 01:11:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73771, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71771 - Login form duplicate messages
Login form duplicate messages
Status: NEW
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-08 00:11 UTC by Jon
Modified: 2014-11-18 01:11 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Duplicate error messages (40.44 KB, image/png)
2014-10-08 00:11 UTC, Jon
Details
Similarly, if you hit an error you see two alert boxes. We should probably only show one. (49.83 KB, image/png)
2014-10-08 00:18 UTC, Jon
Details

Description Jon 2014-10-08 00:11:51 UTC
Created attachment 16699 [details]
Duplicate error messages

Navigate to Special:Watchlist whilst not logged in
You get two messages.

Expected:
You should just get the first styled message

We should look to consolidate our own custom code with that in core...
Comment 1 Bingle 2014-10-08 00:15:17 UTC
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/dDj3Id6L
Comment 2 Jon 2014-10-08 00:18:34 UTC
I'd suggest styling the alert box instead of headmsg and using our own custom message which includes the bold text.
Comment 3 Jon 2014-10-08 00:18:45 UTC
Created attachment 16700 [details]
Similarly, if you hit an error you see two alert boxes. We should probably only show one.
Comment 4 Jon 2014-10-08 18:26:00 UTC
Florna seems to have made a start to this - might be some ideas there - https://gerrit.wikimedia.org/r/#/c/165248/4
Comment 5 Florian 2014-10-08 18:27:46 UTC
Yeah, it was an idea (before i saw this bug today), maybe we can use it someway :) Comments are welcome!
Comment 6 Jon 2014-10-08 21:43:56 UTC
https://gerrit.wikimedia.org/r/165634 will take care of this if it was to move to stable.

I think we need to kill our custom login code.
Comment 7 Gerrit Notification Bot 2014-10-13 15:13:26 UTC
Change 165634 had a related patch set uploaded by Florianschmidtwelzow:
Use desktop login/account creation form in alpha

https://gerrit.wikimedia.org/r/165634
Comment 8 Gerrit Notification Bot 2014-10-21 18:55:45 UTC
Change 165634 merged by jenkins-bot:
Use desktop login/account creation form in alpha

https://gerrit.wikimedia.org/r/165634
Comment 9 Jon 2014-10-21 21:41:26 UTC
This is now live in alpha. Need to propagate these changes to stable.
Comment 10 Florian 2014-11-16 02:10:54 UTC
Jon, the patch is live since wmf5 (since Wednesday, 29 October 2014 for all Wikipedias). We had no related bug reports (iirc) and it seems to work fine, what do you think: Can we move it to beta? :)
Comment 11 Jon 2014-11-18 01:11:11 UTC
Using the desktop login form has various issues still and is not going to be ready any time soon.

Is there any way we can make the stable/beta site version of our existing login form use this mechanism and override the messages?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links