Last modified: 2014-10-12 18:23:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73772, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71772 - Argument 1 passed to SidebarHookHandlers::onParserAfterParse() must be an instance of Parser
Argument 1 passed to SidebarHookHandlers::onParserAfterParse() must be an ins...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Math (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-08 00:49 UTC by Aude
Modified: 2014-10-12 18:23 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Aude 2014-10-08 00:49:35 UTC
Catchable fatal error: Argument 1 passed to Wikibase\Client\Hooks\SidebarHookHandlers::onParserAfterParse() must be an instance of Parser, none given at /srv/mediawiki/php-1.25wmf1/extensions/Wikidata/extensions/Wikibase/client/includes/hooks/SidebarHookHandlers.php on line 123

http://en.wikipedia.org/w/index.php?title=Special:MathShowImage&hash=24a17d2e2b000c187e42eafb8faf1059&mode=0

Backtrace:
#0 /srv/mediawiki/php-1.25wmf1/extensions/Wikidata/extensions/Wikibase/client/includes/hooks/SidebarHookHandlers.php(123): Wikibase\Client\Hooks\SidebarHookHandlers::onParserAfterParse()
#1 [internal function]: Wikibase\Client\Hooks\SidebarHookHandlers::onParserAfterParse()
#2 /srv/mediawiki/php-1.25wmf1/includes/Hooks.php(206): call_user_func_array('\Wikibase\Clien...', Array)
#3 /srv/mediawiki/php-1.25wmf1/includes/GlobalFunctions.php(3991): Hooks::run('ParserAfterPars...', Array, NULL)
#4 /srv/mediawiki/php-1.25wmf1/extensions/Math/SpecialMathShowImage.php(97): wfRunHooks('ParserAfterPars...')
#5 /srv/mediawiki/php-1.25wmf1/includes/specialpage/SpecialPage.php(363): SpecialMathShowImage->execute(NULL)
#6 /srv/mediawiki/php-1.25wmf1/includes/specialpage/SpecialPageFactory.php(562): SpecialPage->run(NULL)
#7 /srv/mediawiki/php-1.25wmf1/includes/MediaWiki.php(275): SpecialPageFactory::executePath(Object(Title), Object(RequestContext))
#8 /srv/mediawiki/php-1.25wmf1/includes/MediaWiki.php(584): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.25wmf1/includes/MediaWiki.php(435): MediaWiki->main()
#10 /srv/mediawiki/php-1.25wmf1/index.php(46): MediaWiki->run()
#11 /srv/mediawiki/w/index.php(3): require('/srv/mediawiki/...')
Comment 1 Gerrit Notification Bot 2014-10-08 08:06:00 UTC
Change 165440 had a related patch set uploaded by Thiemo Mättig (WMDE):
Workaround for invalid ParserAfterParse hook call

https://gerrit.wikimedia.org/r/165440
Comment 2 Aude 2014-10-08 12:22:08 UTC
problem is that SpecialMathShowImage is calling wfRunHooks('ParserAfterParse') with no parameters, inconsistent with the hook definition:

www.mediawiki.org/wiki/Manual:Hooks/ParserAfterParse

so, in the Wikibase hook handler, $parser and other parameters are null.

it would be much better if Math would directly call whatever specific method(s) that can save the file, rather than triggering the hook.
Comment 3 physikerwelt 2014-10-08 14:51:43 UTC
would it be better to user wfRunHooks('ParserAfterParse' , '', null ); instead
Comment 4 Gerrit Notification Bot 2014-10-08 15:00:16 UTC
Change 165488 had a related patch set uploaded by Aude:
Workaround for invalid ParserAfterParse hook call

https://gerrit.wikimedia.org/r/165488
Comment 5 Gerrit Notification Bot 2014-10-09 18:22:53 UTC
Change 165440 merged by jenkins-bot:
Workaround for invalid ParserAfterParse hook call

https://gerrit.wikimedia.org/r/165440
Comment 6 Gerrit Notification Bot 2014-10-09 18:22:57 UTC
Change 165488 merged by jenkins-bot:
Workaround for invalid ParserAfterParse hook call

https://gerrit.wikimedia.org/r/165488

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links