Last modified: 2014-10-14 18:48:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73779, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71779 - Flow: Support wgCapitalLinks = false
Flow: Support wgCapitalLinks = false
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-08 06:53 UTC by Matthew Flaschen
Modified: 2014-10-14 18:48 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2014-10-08 06:53:09 UTC
Currently, the tests fail if wgCapitalLinks is false, which is currently the case if you have CirrusSearch enabled in MediaWiki-Vagrant.

However, we should fix this in our own right.  It will be required anyway if we deploy to Wiktionary.  I think it may be enough to simply make Flow's topic namespace an alwaysCapitalizedNamespace (which I think would require a hook into core)  The alternative could be to set wgCapitalLinkOverrides to true for the topic namespace.  I'm not sure which is better.  See https://git.wikimedia.org/blob/mediawiki%2Fcore.git/3a0b5d4d0ed8c497e1a96efdae237fb30a1ccd75/includes%2FMWNamespace.php#L362 

I haven't yet confirmed Flow is okay with the actual human-readable namespace (e.g. Wikipedia talk) being case-sensitive.  For that one, we'll have to support it if/when we run on wgCapitalLinks = false wikis, since e.g. on Wiktionary https://en.wiktionary.org/wiki/Talk:Apple and https://en.wiktionary.org/wiki/Talk:apple are the talk pages for entirely different entries.
Comment 1 Matthew Flaschen 2014-10-08 18:00:37 UTC
I tested with:

$wgCapitalLinkOverrides[NS_TOPIC] = true;

This could go in Flow.php I think.

In theory, modifying alwaysCapitalizedNamespaces would be slightly better I think.  That would require a hook, though.
Comment 2 Matthew Flaschen 2014-10-08 18:00:56 UTC
I forgot to say, the test worked to get the QUnit passing.
Comment 3 Danny Horn 2014-10-08 18:43:10 UTC
in backlog: https://trello.com/c/2WddEysl
Comment 4 spage 2014-10-14 18:48:03 UTC
Seems to me Flow should not assume topics are always capitalized, since internally its UUIDs are lowercase. Maybe the tests could query &meta=siteinfo&siprop=namespaces to find out if case="case-sensitive" or "first-letter".

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links