Last modified: 2014-10-17 09:05:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73780, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71780 - Error on video file pages
Error on video file pages
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ImageMetrics (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-08 07:54 UTC by Gilles Dubuc
Modified: 2014-10-17 09:05 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Gilles Dubuc 2014-10-08 07:54:12 UTC
TypeError: $file.attr(...) is undefined
	
data.fileType = $file.attr( 'alt' ).split( '.' ).pop();

The source of the issue is this line:

$file = $( '#file' ).find( 'img' );

Which assumes the presence of an image and passes the empty jQuery object further along.

I think this might be a race condition to a degree, as the image might be part of the DOM returned by the server, but TMH hijacks it as soon as it can.
Comment 1 Gerrit Notification Bot 2014-10-08 08:11:07 UTC
Change 165441 had a related patch set uploaded by Gilles:
Don't try to log metrics if it's not an image

https://gerrit.wikimedia.org/r/165441
Comment 2 Gerrit Notification Bot 2014-10-08 14:44:58 UTC
Change 165441 merged by jenkins-bot:
Don't try to log metrics if it's not an image

https://gerrit.wikimedia.org/r/165441
Comment 3 Gilles Dubuc 2014-10-17 09:04:47 UTC
Hello, pywikibot

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links