Last modified: 2014-10-21 18:18:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73795, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71795 - VisualEditor: Proposed external links should be validated before being created
VisualEditor: Proposed external links should be validated before being created
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Lowest enhancement
: ---
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-08 13:54 UTC by Ritu Swain
Modified: 2014-10-21 18:18 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Ritu Swain 2014-10-08 13:54:46 UTC
Open the link inspector and just type in double slash(forward), click done.It gets inserted in the CE as an external link.
The external links should be validated for correct format.
Comment 1 Andre Klapper 2014-10-08 16:31:47 UTC
[Problem is unrelated to specific browsers hence removing 'Web browser' field entry. "should be" -> new feature, hence setting 'Severity' to 'enhancement'.]

(In reply to Ritu Swain from comment #0)
> The external links should be validated for correct format.

Do you have any definition (or even regular expression) in mind for "correct format"?
*If* the scope of the link inspector is supposed to support URIs as per http://www.ietf.org/rfc/rfc3986.txt this could become complex...
Comment 2 Ritu Swain 2014-10-08 18:30:03 UTC
(In reply to Andre Klapper from comment #1)
> [Problem is unrelated to specific browsers hence removing 'Web browser'
> field entry. "should be" -> new feature, hence setting 'Severity' to
> 'enhancement'.]
> 
> (In reply to Ritu Swain from comment #0)
> > The external links should be validated for correct format.
> 
> Do you have any definition (or even regular expression) in mind for "correct
> format"?
> it could follow the HTTP URL syntax.But right now anything that has a double slash("//" or "//foo") is taken as an external link.
Comment 3 Andre Klapper 2014-10-08 22:56:16 UTC
(In reply to Ritu Swain from comment #2)
> it could follow the HTTP URL syntax.

What is that syntax? What about other protocols? How to define what's "valid" without excluding other valid URLs?
Comment 4 Ritu Swain 2014-10-10 17:00:52 UTC
I raised this  ticket, because i thought there should be some sort of client-side validation for external link entries.What I mean is, when i type in a "//" or "//foo" then even the  external link icon should not get inserted to the page. Right now it is only after saving the page,you would see that "//" is saved as a text and not a link.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links