Last modified: 2014-10-16 23:41:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73825, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 71825 - VisualEditor: [Regression pre-wmf3] Citation dialog inserts empty reference
VisualEditor: [Regression pre-wmf3] Citation dialog inserts empty reference
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High major
: VE-deploy-2014-10-09
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-08 19:19 UTC by Rummana Yasmeen
Modified: 2014-10-16 23:41 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Screenshot (109.97 KB, image/png)
2014-10-08 19:30 UTC, Rummana Yasmeen 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-10-08 19:19:30 UTC 
Steps to reproduce:


1.Open a page with VE
2.Insert Cite>Website/News/Journal etc

Observed Result:
All citation notes are getting added as basic reference, opening them opens the basic reference dialog instead of the citation dialog.

Environment:Betalabs
Comment 1 Rummana Yasmeen 2014-10-08 19:30:32 UTC 
Created attachment 16719 [details]
Screenshot
Comment 2 Roan Kattouw 2014-10-08 19:32:33 UTC 
This is happening because the references inserted by the citation dialog are empty, they don't have a template in them like they should.
Comment 3 Gerrit Notification Bot 2014-10-08 19:56:20 UTC 
Change 165592 had a related patch set uploaded by Catrope:
Followup b8d8a5b: pass selections, not ranges, to SurfaceFragment#clone

https://gerrit.wikimedia.org/r/165592
Comment 4 Gerrit Notification Bot 2014-10-08 19:57:09 UTC 
Change 165593 had a related patch set uploaded by Catrope:
Followup b8d8a5b: pass selections, not ranges, to SurfaceFragment#clone

https://gerrit.wikimedia.org/r/165593
Comment 5 Gerrit Notification Bot 2014-10-08 20:04:15 UTC 
Change 165592 merged by jenkins-bot:
Followup b8d8a5b: pass selections, not ranges, to SurfaceFragment#clone

https://gerrit.wikimedia.org/r/165592
Comment 6 Gerrit Notification Bot 2014-10-08 20:06:13 UTC 
Change 165593 merged by jenkins-bot:
Followup b8d8a5b: pass selections, not ranges, to SurfaceFragment#clone

https://gerrit.wikimedia.org/r/165593
Comment 7 James Forrester 2014-10-08 20:14:51 UTC 
(Core pull-through not yet merged but otherwise fixed.)
Comment 8 Rummana Yasmeen 2014-10-08 22:01:49 UTC 
Verified the fix in Betalabs
Comment 9 Rummana Yasmeen 2014-10-09 23:01:57 UTC 
Verified the fix in test2
Comment 10 Rummana Yasmeen 2014-10-16 23:41:10 UTC 
Verified the fix in production
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links