Last modified: 2014-11-17 09:21:10 UTC
I have written a new extension for custom inline-diff with block move support(WikEdDiff, https://www.mediawiki.org/wiki/Extension:WikEdDiff). This extension needs a new hook. E.g. "CustomDifferenceEngine" in /includes/diff/DifferenceEngine.php in function generateTextDiffBody after "$ntext = str_replace( "\r\n", "\n", $ntext );": # Custom difference engine hook wfRunHooks( 'CustomDifferenceEngine', array( &$otext, &$ntext, &$diffText ) ); if ( $diffText !== false ) { wfProfileOut( __METHOD__ ); return $diffText; } I am new to git/Gerrit and wanted to discuss this here first.
Thanks for taking the time to report this! In case you don't get feedback here I'd recommend to just put an initial patch into Gerrit, to iterate on. See http://www.mediawiki.org/wiki/Gerrit/Tutorial and https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker
OK, I have committed this, please see https://gerrit.wikimedia.org/r/#/c/166143/
Thank you!
Change 166143 had a related patch set uploaded by Martineznovo: Add a hook for custom diff engines (WikEdDiff) https://gerrit.wikimedia.org/r/166143
I've just updated the commit message so it's properly linked to the bug
Change 169677 had a related patch set uploaded by Cacycle: Add a hook for custom diff engines (WikEdDiff) https://gerrit.wikimedia.org/r/169677
Change 166143 had a related patch set uploaded by PleaseStand: Add a hook for custom diff engines (WikEdDiff) https://gerrit.wikimedia.org/r/166143
Change 169677 abandoned by PleaseStand: Add a hook for custom diff engines (WikEdDiff) Reason: Squashed into Change-Id: I9da63c1ceb339bfeba7beddc712be51977b95f65 https://gerrit.wikimedia.org/r/169677
Change 170716 had a related patch set uploaded by Cacycle: Add a hook for custom difference engine (WikEdDiff) https://gerrit.wikimedia.org/r/170716
Change 170716 abandoned by Cacycle: Add a hook for custom difference engine (WikEdDiff) Reason: Should have gone into https://gerrit.wikimedia.org/r/#/c/166143/ https://gerrit.wikimedia.org/r/170716
Change 170723 had a related patch set uploaded by Cacycle: Add a hook for custom difference engine (WikEdDiff) https://gerrit.wikimedia.org/r/170723
Change 170723 abandoned by Cacycle: Add a hook for custom difference engine (WikEdDiff) Reason: Should have gone into https://gerrit.wikimedia.org/r/#/c/166143/ https://gerrit.wikimedia.org/r/170723
