Last modified: 2014-10-11 00:49:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73926, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 71926 - Fix or remove GuidedTour preloading
Fix or remove GuidedTour preloading
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
GuidedTour (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-11 00:49 UTC by Matthew Flaschen
Modified: 2014-10-11 00:49 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matthew Flaschen 2014-10-11 00:49:23 UTC 
The preloading at https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGuidedTour.git/7018887bceb7603496ee70a6a4a4664522078029/modules%2Fmediawiki.libs.guiders%2Fmediawiki.libs.guiders.js#L776 is broken, since it treats guider.next as a string whereas it's now a function (https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGuidedTour.git/7018887bceb7603496ee70a6a4a4664522078029/modules%2Fext.guidedTour.lib%2Fext.guidedTour.lib.Step.js#L852).

Luckily, there is sanity check to make sure the ID is defined.  Since the function shouldn't appear in that associative array, it should correctly fallback to just not pre-loading.

We can probably just remove this functionality for now.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links