Last modified: 2014-10-11 00:59:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73927, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71927 - shouldSkip and transition do not properly execute on next/prev
shouldSkip and transition do not properly execute on next/prev
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
GuidedTour (Other open bugs)
master
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: code-update-regression
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-11 00:59 UTC by Matthew Flaschen
Modified: 2014-10-11 00:59 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthew Flaschen 2014-10-11 00:59:12 UTC
shouldSkip used to execute correctly when you clicked next.  It would first get the ID of the next guider, then see if skipping was needed.  See https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGuidedTour.git/40e856360e4ba377242c172b036477aebf740ad9/modules%2Fmediawiki.libs.guiders%2Fmediawiki.libs.guiders.js#L774 .

The same should happen with transition, but now it works for neither legacy shouldSkip nor AFAICT transition.

For an example of the regression on legacy, try going to https://en.wikipedia.org/wiki/Wikipedia:TWA/1/Start?tour=twa1&step=6 then click next.

There is a shouldSkip on step 7 (the one you hit when you click next):

shouldSkip: function () {
                return mw.config.get( 'wgUserId' )  !== null;
}

Thus, it should automatically skip step 7, since you're logged in.  However, this doesn't work.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links