Last modified: 2014-10-22 17:20:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73945, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 71945 - MediaWiki UI shows unintentionally on Categories and Contributions due to incorrect use of getConfig return value


Summary:	MediaWiki UI shows unintentionally on Categories and Contributions due to inc...

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	MediaWiki UI (Other open bugs)
Version:	1.25-git
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-10-11 09:16 UTC by Matthew Flaschen
Modified:	2014-10-22 17:20 UTC (History)
CC List:	7 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Flags:	greg: Backport_WMF+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Matthew Flaschen 2014-10-11 09:16:32 UTC

This affects wmf/1.25wmf2 (currently on all Wikipedias) but not 1.25wmf3 or master.  It happened to get fixed by a155ac55ea0854b0989efe23158d33b5a548f14e .

Basically, Special:Categories and Special:Contributions were calling:

if ( $this->getConfig( 'UseMediaWikiUIEverywhere' ) ) {

(passing an unused parameter to a no-args method, then using the config object as a boolean)

instead of the correct:

if ( $this->getConfig()->get( 'UseMediaWikiUIEverywhere' ) ) {

I think we should backport the fix on Monday (it can be done by making the above change rather than the whole a155ac55) since it's very inconsistent (only the button is MW UI, not the text boxes or checkboxes) and Special:Contributions is a prominent page.

Comment 1 Jon 2014-10-11 15:01:41 UTC

See my email to design mailing list UI form standardisation groans

I say we just wait till it corrects itself Thursday. It's just a blue button.

Comment 2 Greg Grossmeier 2014-10-12 21:43:53 UTC

Matt/Jon: If you want to SWAT this out on Tuesday morning that's totally fine.

Comment 3 Jon 2014-10-12 21:54:22 UTC

I don't. it's just a fully functional button that just happens to be blue that will go away 2 days later. Seems like a bunch of effort for the sake of 2 days.

Comment 4 Jon 2014-10-22 17:20:09 UTC

This is now fixed.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links