Last modified: 2014-11-14 23:51:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73947, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71947 - Incorrect tagging of edits on some Wikipedias – AbuseFilter's diff and the real diff are not the same
Incorrect tagging of edits on some Wikipedias – AbuseFilter's diff and the re...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
AbuseFilter (Other open bugs)
master
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
https://en.wikipedia.org/wiki/Wikiped...
: code-update-regression, hhvm
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-11 10:36 UTC by Bartosz Dziewoński
Modified: 2014-11-14 23:51 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bartosz Dziewoński 2014-10-11 10:36:02 UTC
Reported at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Irrelevant_tags , quoting below:

Why would [http://en.wikipedia.org/w/index.php?title=M.R._Organisation_Limited&curid=44080416&diff=629153289&oldid=629153016 this] edit get [[Special:Tags|tagged]] with copyright violation template removed and speedy deletion template removed if the edit did not remove the templates? Is this a bug in the tags system? The user used HHVM and VisualEditor, is this relevant? [[Special:Contributions/109.79.177.119|109.79.177.119]] ([[User talk:109.79.177.119|talk]]) 09:43, 11 October 2014 (UTC)

(The page in question has unfortunately been deleted since, but the data is still there, just hidden.)

I did some quick investigating:

* If you review the page history a bit (which I managed to do before
  it was deleted), the two templates were indeed removed at a point
  (and that was correctly tagged) and then restored, with the next
  edit being tagged incorrectly.
* You can examine the logic that led to that edit being tagged at
  [[Special:AbuseFilter/examine/log/10945503]] – if you look at the
  row described as "Unified diff of changes made by edit", you can see
  that AbuseFilter really thinks these tags were removed in that edit
  (although they were not).
Comment 2 Bartosz Dziewoński 2014-10-11 12:20:41 UTC
(Adding 'hhvm' keyword just in case it's related to that.)
Comment 3 Helder 2014-11-14 23:50:35 UTC
Here is another example on Portuguese Wikipedia:
https://pt.wikipedia.org/wiki/Special:AbuseFilter/examine/log/1898713?uselang=en
https://pt.wikipedia.org/w/index.php?diff=40613438&uselang=en
The string "{{ESR2|" is in "removed_lines" but not in "added_lines". However, it should not be in the "removed_lines", because it is still in the new revision:
https://pt.wikipedia.org/w/index.php?title=Zats_Boy&action=edit&oldid=40613438

This was reported on
https://pt.wikipedia.org/wiki/WP:CP?oldid=40613984#Falso_positivo_na_etiqueta

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links