Last modified: 2014-10-27 19:25:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74041, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72041 - Undocumented delete confirmation interface change
Undocumented delete confirmation interface change
Status: NEW
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Matthew Flaschen
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-14 16:17 UTC by Kunal Mehta (Legoktm)
Modified: 2014-10-27 19:25 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Current MonoBook with regression (70.58 KB, image/png)
2014-10-14 16:17 UTC, Kunal Mehta (Legoktm)
Details
Older core/MonoBook without regression (35.71 KB, image/png)
2014-10-14 16:17 UTC, Kunal Mehta (Legoktm)
Details

Description Kunal Mehta (Legoktm) 2014-10-14 16:17:19 UTC
Created attachment 16762 [details]
Current MonoBook with regression

Didn't test any other skins...

See attachments. Originally reported at <https://en.wikipedia.org/w/index.php?title=Wikipedia:Administrators%27_noticeboard&oldid=629586567#Delete_button>

Likely cause: https://gerrit.wikimedia.org/r/#/c/154121
Comment 1 Kunal Mehta (Legoktm) 2014-10-14 16:17:44 UTC
Created attachment 16763 [details]
Older core/MonoBook without regression
Comment 2 Kunal Mehta (Legoktm) 2014-10-14 16:26:28 UTC
Hmm, appears to be present in the other skins as well.
Comment 3 Matthew Flaschen 2014-10-26 05:55:49 UTC
Alright, so this appearance change is indeed caused by that commit.  I believe it is caused by the part that switches from tables to divs ("Stop using tables use divs instead. It's the future!")

I see three main options:

1. Keep this appearance and better communicate it.  I agree the communication here was lax, but it's really not that different.  I'm not sure, but I think this layout is also more consistent with the general UI direction.

2. Keep it as divs and use display: table-cell or display: table (I think this still might require markup change, and it needs to be checked on mobile, but it's otherwise pretty straightforward).  The downside is that it's still tabular layout, and it's not clear to me we actually want tabular layout here.

3. Go back to table elements, but keep the MW UI styling changes.

I recommend #1.
Comment 4 Kunal Mehta (Legoktm) 2014-10-27 19:06:09 UTC
I think #2 would be preferred, but #1 is also reasonable if #2 is not worth the effort.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links