Last modified: 2014-11-15 22:08:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74048, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72048 - VisualEditor: [Regression] VE corruption issue(?) moving pre-existing categories to the middle of the page
VisualEditor: [Regression] VE corruption issue(?) moving pre-existing categor...
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Data Model (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-nextup
Assigned To: Editing team bugs – take if you're interested!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-14 18:52 UTC by WhatamIdoing
Modified: 2014-11-15 22:08 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description WhatamIdoing 2014-10-14 18:52:03 UTC
In https://fr.wikipedia.org/w/index.php?title=Église_orthodoxe_celtique&diff=prev&oldid=108126191 we see:

Ferrette n[[Catégorie:Église orthodoxe en France|Celtique]]'a jamais pu présenter la preuve de cette consécration. 


This doesn't make any sense at all.  Please figure out a way to stop putting categories in the middle of sentences.


In https://fr.wikipedia.org/w/index.php?title=Boulimie&diff=prev&oldid=108006315 we find:

* la boulimie perdure<ref>20 % [[Catégorie:Borderline]][[Catégorie:Trouble des conduites alimentaires]][[Catégorie:Dépendance comportementale]]des patients présentent encore de la boulimie après 5 à {{nombre|10|ans}} de suivi.</ref>


This is wrong.  Please figure out of a way to stop putting categories in the middle of foonotes.


In https://fr.wikipedia.org/w/index.php?title=Bloomsbury_%28Londres%29&diff=108070420&oldid=106082114 we discover:

[[Samuel Coleridge-Taylor]], musicien et compositeur, naît au N{{º}} 15 Theobald's Road<ref>{{en}}[http://www.bl.uk/onlinegallery/features/blackeuro/coleridgebackground.html Coleridge-Taylor's e][[Catégorie:Camden (borough londonien)]][http://www.bl.uk/onlinegallery/features/blackeuro/coleridgebackground.html arly life], site officiel de la ''British Library''</ref>.


This is unwanted.  Please figure out a way to stop putting categories in the middle of an external link inside footnotes.
Comment 1 ssastry 2014-10-14 23:34:42 UTC
Did something change with how VE generates category link tags? For one, I don't remember but weren't new link tags being added to a specific section of the DOM rather than where the cursor is. For another, it looks like Parsoid isn't recognizing these links are "new" category links (we would still serialize the link tags where they were, but on a new line by itself -- whereas here, it seems to be rendering inline, which we only do for original links found in wikitext to prevent dirty diffs).

Roan: can you take a look?

Meanwhile, independently, for all new tags, Parsoid should stop relying on clients to add new category link tags at the beginning/end and instead collect them and serialize them in a specific area. This would be a low priority task if this was just something that changed in VE that can be readily fixed.
Comment 2 WhatamIdoing 2014-10-15 05:15:37 UTC
Parsoid shouldn't be recognizing these cats as "new", because they aren't.  All of those diffs show categories being moved out of its correct location and stuffed into a nonsensical one.  There are no new categories being added here.
Comment 3 ssastry 2014-10-15 05:26:22 UTC
This is very likely a VE issue then -- the HTML for these categories probably got moved out of their original correct location to where they were found (and which Parsoid serializes).

If not new, then Parsoid cannot arbitrarily move them from where they showed up in the DOM to a different place since that could introduce dirty diffs.
Comment 4 ssastry 2014-10-15 15:18:41 UTC
On irc, Roan thinks this is a VE/data-corruption bug. Re-assigning.
Comment 5 NicoV 2014-10-25 08:10:54 UTC
Any news on this ?
It's still happening, and once it started it seems to be worse at the next edit:
https://fr.wikipedia.org/w/index.php?title=Les_Colombes_du_Roi-Soleil&diff=prev&oldid=108398195
https://fr.wikipedia.org/w/index.php?title=Les_Colombes_du_Roi-Soleil&diff=next&oldid=108398195
Comment 6 James Forrester 2014-10-27 22:02:33 UTC
(In reply to NicoV from comment #5)
> Any news on this ?
> It's still happening, and once it started it seems to be worse at the next
> edit:
> https://fr.wikipedia.org/w/index.php?title=Les_Colombes_du_Roi-
> Soleil&diff=prev&oldid=108398195
> https://fr.wikipedia.org/w/index.php?title=Les_Colombes_du_Roi-
> Soleil&diff=next&oldid=108398195

That's not the same bug – it's clearly an issue in Parsoid, and a much more severe one than some trivial (if unhelpful) moving around of valid wikitext. I've created bug 72591 for that.

Please, in future, open a new bug when a bug's symptoms are suddenly significantly different. That bug needs much more urgent attention than this, and it's only because I was reviewing our overall set that I even saw this. :-(
Comment 7 James Forrester 2014-10-27 22:04:16 UTC
(In reply to James Forrester from comment #6)
> (In reply to NicoV from comment #5)
> > Any news on this ?
> > It's still happening, and once it started it seems to be worse at the next
> > edit:
> > https://fr.wikipedia.org/w/index.php?title=Les_Colombes_du_Roi-
> > Soleil&diff=prev&oldid=108398195
> > https://fr.wikipedia.org/w/index.php?title=Les_Colombes_du_Roi-
> > Soleil&diff=next&oldid=108398195
> 
> That's not the same bug – it's clearly an issue in Parsoid, and a much more
> severe one than some trivial (if unhelpful) moving around of valid wikitext.
> I've created bug 72591 for that.
> 
> Please, in future, open a new bug when a bug's symptoms are suddenly
> significantly different. That bug needs much more urgent attention than
> this, and it's only because I was reviewing our overall set that I even saw
> this. :-(

Belay that; I got confused by people shouting at me in IRC and giving me multiple links at once.
Comment 8 NicoV 2014-10-27 22:12:33 UTC
Well, I don't see any real difference between the first edit reported in my comment (#5), and the third example reported in the description of this bug by WhatamIdoing. They both involve categories moved in a reference, in a middle of an external link who has been split in two...

I was the one who reported the problem 2 weeks ago on enwiki, it already seemed severe to me at the time.
Comment 9 NicoV 2014-11-15 00:18:00 UTC
Any news on this bug that keeps damaging articles?

https://fr.wikipedia.org/w/index.php?title=Indicateur_ordinal&diff=109016166&oldid=101347848
Comment 10 WhatamIdoing 2014-11-15 21:55:32 UTC
NicoV, do you know how to make this happen?  Bugs that can be consistently reproduced are usually easier to solve (and it's always easier to know that you have actually solved them).
Comment 11 NicoV 2014-11-15 22:08:01 UTC
Not the slightest idea, just tired of fixing articles.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links