Last modified: 2014-11-12 23:31:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74112, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 72112 - VisualEditor Mobile: [Regression wmf3] The fields inside Citations dialog are appearing at a fixed rather than whole-screen width in mobile VE


Summary:	VisualEditor Mobile: [Regression wmf3] The fields inside Citations dialog are...

Status:	VERIFIED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Mobile (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low normal
Target Milestone:	VE-deploy-2014-11-05 (1.25wmf7)
Assigned To:	James Forrester

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-10-16 00:39 UTC by Rummana Yasmeen
Modified:	2014-11-12 23:31 UTC (History)
CC List:	7 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Screenshot (26.33 KB, image/png) 2014-10-16 00:39 UTC, Rummana Yasmeen	Details
Screenshot (27.14 KB, image/png) 2014-10-31 21:58 UTC, Rummana Yasmeen	Details
Screenshot (44.62 KB, image/jpeg) 2014-10-31 22:10 UTC, Rummana Yasmeen	Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-10-16 00:39:30 UTC

Created attachment 16782 [details]
Screenshot

Steps to reproduce:

1.Open a page with mobile VE
2.Open any citation dialog like Cite>Website/book

Observed Result:
The fields inside Citations dialog are appearing at a much smaller size

See the screenshot attached

Comment 1 James Forrester 2014-10-20 15:00:29 UTC

This is almost certainly because of the MediaWiki theme; maybe that now actually sets fields' default width, and the previous theme wasn't?

Comment 2 Gerrit Notification Bot 2014-10-30 00:05:17 UTC

Change 169968 had a related patch set uploaded by Jforrester:
Set input/menu widgets to have a max-width expanding to 100% rather than hard-coded

https://gerrit.wikimedia.org/r/169968

Comment 3 Gerrit Notification Bot 2014-10-30 00:08:45 UTC

Change 169968 merged by jenkins-bot:
Set input/menu widgets to have a max-width expanding to 100% rather than hard-coded

https://gerrit.wikimedia.org/r/169968

Comment 4 etonkovidova 2014-10-30 23:52:11 UTC

confirmed in betalabs. 

Previously it was: 
oo-ui-textInputWidget {
	.	 width: 20em;
}


After the fix: 
.oo-ui-textInputWidget {

	.	 width: 100%;
	.	 max-width: 50em;

}

Comment 5 Rummana Yasmeen 2014-10-31 21:58:30 UTC

Created attachment 16986 [details]
Screenshot

Its still not taking full width .Reopening it.

Comment 6 James Forrester 2014-10-31 22:05:46 UTC

It's not meant to. This is wide enough for tablets and phones.

Comment 7 Rummana Yasmeen 2014-10-31 22:10:20 UTC

Created attachment 16987 [details]
Screenshot

Is it okay if the width appears this way in tablet?

Comment 8 Rummana Yasmeen 2014-11-12 23:31:28 UTC

Verified the fix in production

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links