Last modified: 2014-10-22 01:45:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74121, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72121 - VisualEditor: Link inspector inside dialog is clipped against dialog boundary, which makes it too small
VisualEditor: Link inspector inside dialog is clipped against dialog boundary...
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal major
: VE-deploy-nextup
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-16 02:00 UTC by Erik Moeller
Modified: 2014-10-22 01:45 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
buggy link dialog (150.32 KB, image/png)
2014-10-16 02:00 UTC, Erik Moeller
Details

Description Erik Moeller 2014-10-16 02:00:25 UTC
Created attachment 16786 [details]
buggy link dialog

Links don't correctly autocomplete when adding them from the references dialog and not the main editor (see screenshot; Chrome, en.wp today).
Comment 1 Roan Kattouw 2014-10-22 01:37:53 UTC
The links are autocompleting just fine, it's just that the dropdown is so small that you only see one suggestion, and the rest can be accessed by scrolling (notice the scrollbar).

What we should really be doing though, is not clip the link inspector against the boundaries of the dialog it's in, but allow it to go beyond those boundaries. That's a bit fiddly but probably not very hard.
Comment 2 Roan Kattouw 2014-10-22 01:44:55 UTC
I need to pick Trevor's brain about this. Right now the WindowManager for inspectors is in the localOverlay, which is a sibling of the ce-surface (and so is inside the iframe). It would be interesting to explore putting this in the globalOverlay, but then that would be nasty for scrollable surfaces (or even surfaces embedded in a scrollable container; like, for example, an iframe) where the anchor moves as you scroll: in a globalOverlay situation, we'd have to manually reposition the inspector to account for scrolling, but with the localOverlay as it is we get this for free.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links