Last modified: 2014-10-22 03:03:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74150, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72150 - VisualEditor: [Regression] Clicking the link tool or Ctrl+K keyboard command on an auto-numbered external link triggers the wrong (annotation) link inspector
VisualEditor: [Regression] Clicking the link tool or Ctrl+K keyboard command ...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: Normal enhancement
: VE-deploy-2014-10-23 (1.25wmf5)
Assigned To: Roan Kattouw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-16 20:56 UTC by WhatamIdoing
Modified: 2014-10-22 03:03 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of link dialog (23.36 KB, image/png)
2014-10-16 23:55 UTC, WhatamIdoing
Details

Description WhatamIdoing 2014-10-16 20:56:04 UTC
Steps to reproduce:

1.  Open a page that already contains an external link without a label: [http://example.com].

2.  Try to change that link to [http://example.com anything].  No fair removing the whole link and re-adding it.


Results:

Yeah, I couldn't figure out how to do that either.


(According to the bug titles, bug 51309, bug 53505, and maybe some others address this, but the descriptions don't seem to match the titles very closely.)
Comment 1 Drongou 2014-10-16 21:45:52 UTC
Add label
Change selection to select all except the last letter
type : anything
delete last letter

not ...
Comment 2 James Forrester 2014-10-16 23:05:06 UTC
1. Select link.
2. Edit link.
3. Click "Add label".

Done?
Comment 3 WhatamIdoing 2014-10-16 23:55:36 UTC
Created attachment 16793 [details]
Screenshot of link dialog
Comment 4 WhatamIdoing 2014-10-16 23:55:59 UTC
Not done.  There's no "Add label" button (see screenshot).
Comment 5 James Forrester 2014-10-16 23:57:02 UTC
(In reply to WhatamIdoing from comment #4)
> Not done.  There's no "Add label" button (see screenshot).

How did you get the wrong link dialog to trigger? Link and reproduction steps please.
Comment 6 WhatamIdoing 2014-10-17 15:21:56 UTC
Steps to reproduce:

1.  1.  Open a page that already contains an external link without a label: [http://example.com], such as   https://en.wikipedia.org/wiki/User:Whatamidoing_%28WMF%29/sandbox?veaction=edit (scroll down to the ==External links== section).

2.  Open the link dialog.

I get the 'wrong' dialog in both Safari 6.2 and Firefox 32 on en.wp, mw.org, and beta labs, so it's not just one version.  Perhaps it's Mac specific?  I've asked Phatom87 (Mozilla Firefox user) for browser and OS information.
Comment 7 Elitre 2014-10-17 15:27:51 UTC
I tried this earlier and works for me in Chrome/Win8 and Safari on my Air. (6.2 isn't the most recent Safari version, but I don't think that matters). Can it be some kind of cache issue?
Comment 8 Elitre 2014-10-17 15:29:44 UTC
(Also, works fine in both skins.)
Comment 9 James Forrester 2014-10-17 19:45:34 UTC
Aha, the trick is you're using the toolbar button (or keyboard shortcut) rather than the context menu item. 

This is a regression. It's loading the link annotation editor rather than the link node editor. Clicking the context menu works just fine. Boo.
Comment 10 WhatamIdoing 2014-10-20 23:17:10 UTC
Phatom87 says he's been using "the tab that shows up after clicking on the link."  He's running Mozilla browser version is 32.0.3 and kde Linux 4.14.1.
Comment 11 Gerrit Notification Bot 2014-10-22 02:48:15 UTC
Change 168030 had a related patch set uploaded by Catrope:
Open the linkNode inspector when pressing Ctrl+K on a link node

https://gerrit.wikimedia.org/r/168030
Comment 12 Gerrit Notification Bot 2014-10-22 03:03:34 UTC
Change 168030 merged by jenkins-bot:
Open the linkNode inspector when pressing Ctrl+K on a link node

https://gerrit.wikimedia.org/r/168030

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links