Last modified: 2014-10-17 22:39:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74177, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 72177 - Old revisions should not show edit links.


Summary:	Old revisions should not show edit links.

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	WikidataRepo (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	High major (vote)
Target Milestone:	---
Assigned To:	Wikidata bugs

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-10-17 09:06 UTC by Daniel Kinzler
Modified:	2014-10-17 22:39 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2014-10-17 09:06:34 UTC

When viewing an entity in the context of a diff, or when viewing an old revision, the entity should not be editable. 

However, this is currently handled correctly only for label, description and aliases. The static HTML contains edit links for Statements, Sitrelinks, etc. The JS UI allows editing of Statements, but apparently not for Sitelinks.

Comment 1 Gerrit Notification Bot 2014-10-17 09:15:52 UTC

Change 167177 had a related patch set uploaded by Thiemo Mättig (WMDE):
Don't show dead edit links in diff/old revisions

https://gerrit.wikimedia.org/r/167177

Comment 2 Gerrit Notification Bot 2014-10-17 22:39:29 UTC

Change 167177 merged by jenkins-bot:
Don't show dead edit links in diff/old revisions

https://gerrit.wikimedia.org/r/167177

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links