Last modified: 2014-11-18 00:23:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74191, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72191 - VisualEditor: It's not possible to "Apply changes" from the transclusion dialog after it has been emptied
VisualEditor: It's not possible to "Apply changes" from the transclusion dial...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-10-29 (1.25wmf6)
Assigned To: Alex Monk
:
Depends on:
Blocks: 71701
  Show dependency treegraph
 
Reported: 2014-10-17 17:21 UTC by Bartosz Dziewoński
Modified: 2014-11-18 00:23 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bartosz Dziewoński 2014-10-17 17:21:19 UTC
It's not possible to "Apply changes" from the transclusion dialog after it has been emptied (all template and wikitext blocks in it have been removed), because the button is disabled.

Split off from bug 71701.
Comment 1 James Forrester 2014-10-17 17:51:54 UTC
Yeah; this should be available when there are changes (and on clicking it should remove the transclusion), but it should still be disabled in "insert" mode (as there's nothing to insert).
Comment 2 Gerrit Notification Bot 2014-10-24 23:14:23 UTC
Change 168721 had a related patch set uploaded by Alex Monk:
Allow removing all parts from a transclusion to remove the transclusion

https://gerrit.wikimedia.org/r/168721
Comment 3 Gerrit Notification Bot 2014-10-27 18:13:11 UTC
Change 168721 merged by jenkins-bot:
Allow removing all parts from a transclusion to remove the transclusion

https://gerrit.wikimedia.org/r/168721
Comment 4 etonkovidova 2014-10-27 20:47:11 UTC
Verified in betalabs.
Comment 5 etonkovidova 2014-11-03 21:28:04 UTC
Works correctly in test2.  The bug still exists in production. 

To check if my steps are correct: 

1.Insert a template 'Cite web' 

2. Open template properties for editing - and click 'Show options'. 

3. Click on a trash can symbol - all fields should be empty, but 'Apply changes' is active.

4. clicking on 'Apply changes' should delete the template.
Comment 6 Alex Monk 2014-11-03 21:29:21 UTC
test2 is in production.
Comment 7 Rummana Yasmeen 2014-11-03 21:53:56 UTC
Hey Elena, it has not yet made it to production(en.wiki), since it got fixed in wmf6.Lets check it on production after wednesday deployment.
Comment 8 Alex Monk 2014-11-03 21:57:14 UTC
https://www.mediawiki.org/wiki/MediaWiki_1.25/Roadmap has some more details about what version (see 'Target Milestone') goes to which Wikimedia production wiki and when. Right now this change should be on the following sites in Wikimedia production: mediawikiwiki, testwiki, test2wiki, testwikidatawiki
Comment 9 etonkovidova 2014-11-18 00:23:49 UTC
Verified the fix in production.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links