Last modified: 2014-10-21 05:34:16 UTC
Normally if the externals/httplib2 directory is empty, and there is no httplib2 installed on the system, running pwb.py will report an error and advise the user to use git recursive to install httplib2 into the externals directory. Python 3.4 (and 3.5 nightlys) will 'import' the directory externals/httplib2 even when it is empty, causing pwb.py to fail when it attempts to access 'httplib2.__version__' which doesnt exist in the empty directory externals/httplib2. Steps to reproduce: 1. Uninstall httplib2 from python34 environment. 2. rm -rf externals/httplib2 3. mkdir externals/httplib2 4. python34 pwb.py version Expected results: An error like: Python module httplib2 >= 0.6.0 is required. Did you clone without --recursive? Try running 'git submodule update --init' Actual results: AttributeError: 'module' object has no attribute '__version__'
Change 167533 had a related patch set uploaded by John Vandenberg: Check httplib2.__version__ exists https://gerrit.wikimedia.org/r/167533
Change 167533 merged by jenkins-bot: Check httplib2.__version__ exists https://gerrit.wikimedia.org/r/167533
