Last modified: 2014-10-29 23:50:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74258, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 72258 - VisualEditor: [Regression wmf4] Applying link to an image gives "Uncaught TypeError: Cannot read property 'from' of null ", inspector stays open


Summary:	VisualEditor: [Regression wmf4] Applying link to an image gives "Uncaught Typ...

Status:	VERIFIED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Data Model (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal
Target Milestone:	VE-deploy-2014-10-23 (1.25wmf5)
Assigned To:	Roan Kattouw

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-10-20 14:09 UTC by Ritu Swain
Modified:	2014-10-29 23:50 UTC (History)
CC List:	9 users (show)

See Also:	72259
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
JS errors in test2 (78.07 KB, image/png) 2014-10-20 14:09 UTC, Ritu Swain	Details
Add an attachment (proposed patch, testcase, etc.)

Description Ritu Swain 2014-10-20 14:09:43 UTC

Created attachment 16818 [details]
JS errors in test2

Environment- test2, beta

1>In VE, insert a media(with any settings but no content in "Caption") to blank page.

2> Highlight the image and select link from the toolbar.JS Error-

Uncaught TypeError: Cannot read property 'from' of null 
Uncaught TypeError: Cannot read property 'resolve' of null 
Uncaught TypeError: Cannot read property 'from' of null

at this point.The inspector stays open and clicking on Remove or done does not close it.See screenshot. 

In beta, the JS error(following the above steps) is - Uncaught TypeError: Cannot read property 'from' of null.

Comment 1 Gerrit Notification Bot 2014-10-22 01:56:32 UTC

Change 168021 had a related patch set uploaded by Jforrester:
Prevent JS error in getNativeRange()

https://gerrit.wikimedia.org/r/168021

Comment 2 Gerrit Notification Bot 2014-10-22 01:59:22 UTC

Change 168021 merged by jenkins-bot:
Prevent JS error in getNativeRange()

https://gerrit.wikimedia.org/r/168021

Comment 3 Ritu Swain 2014-10-22 16:00:00 UTC

verified the fix in beta.

Comment 4 etonkovidova 2014-10-23 23:28:50 UTC

Verified in test2(wmf5) - FF, Chrome are fine. 

Safari does not display Language and Link inspectors.

Comment 5 Rummana Yasmeen 2014-10-29 23:50:45 UTC

Verified the fix in production.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links