Last modified: 2014-10-23 12:01:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74328, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72328 - thumb.php: If upscale: Return original image instead of error
thumb.php: If upscale: Return original image instead of error
Status: NEW
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.22.12
All All
: Lowest enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-21 18:27 UTC by Subfader
Modified: 2014-10-23 12:01 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Subfader 2014-10-21 18:27:05 UTC
As title says: If a width largher than the original is called, return original image instead of error.
Comment 1 Tisza Gergő 2014-10-21 20:09:05 UTC
Why should this happen?
Comment 2 Subfader 2014-10-22 16:49:39 UTC
I use this for dynmaic thumb resizing with javascript.
Comment 3 Tisza Gergő 2014-10-22 17:44:59 UTC
How does returning the original help? If you know the size of the original, you can just cap the requested size on the client size. If you don't know the original size, the result will look crappy anyway.

Returning the original image for a practically infinite variety of URLs would AFAIK result in pollution of the varnish cache as the image would have to be stored there for every URL separately.
Comment 4 Subfader 2014-10-23 12:01:24 UTC
Check if viewport has enough width to display the 500px image. 

Call thumb.php?f=Foo.jpg&w=500 > Displays a 500px thumb or a smaller original

How does returning an error help?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links