Last modified: 2014-10-22 19:09:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74343, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72343 - Unclosed table tags cause user input to be lost on page preview with HHVM
Unclosed table tags cause user input to be lost on page preview with HHVM
Status: RESOLVED DUPLICATE of bug 72345
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: hhvm
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-22 04:36 UTC by Mr. Stradivarius
Modified: 2014-10-22 19:09 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mr. Stradivarius 2014-10-22 04:36:35 UTC
Using two unclosed <table> tags on a page sometimes causes MediaWiki to lose user input on page preview.

Steps to reproduce:

1. Edit a page on enwiki and replace all the text in the edit window with the following (without saving):

<table><table>Some text

2. Click on "Show preview". You might need to click a few times; this is an intermittent behaviour. It usually took two or three times for me.

3. The text that we added disappears from the edit window, and the following error is displayed: "Some parts of the edit form did not reach the server; double-check that your edits are intact and try again."

This looks like it might be related to HTML Tidy and bug 65747, but I'm not sure of the real cause.
Comment 1 Mr. Stradivarius 2014-10-22 08:51:15 UTC
Also, I was using HHVM when I saw this happen, which might be relevant. And it might be related to bug 72345.
Comment 2 Mr. Stradivarius 2014-10-22 09:06:22 UTC
After further testing, I've found that this only occurs when I have HHVM enabled, so I'm adding the HHVM keyword.
Comment 3 Kevin Israel (PleaseStand) 2014-10-22 10:16:38 UTC
Yes, I also tried this without HHVM on and I didn't see the problem. After turning it on (by setting the hhvm=true cookie), I do see it, though only for some servers but not others. It's actually only necessary to have a single unclosed table tag.

The problem is indeed that the unclosed table tag is getting through to the output, probably because as stated in an HTML comment, "Tidy was unable to run". That causes wpTextbox1 (the main text box) to end up outside the form in the browser's DOM, and that's why it takes at least two clicks on "Show preview" to reproduce.
Comment 4 Brad Jorsch 2014-10-22 19:09:33 UTC

*** This bug has been marked as a duplicate of bug 72345 ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links