Last modified: 2014-10-29 08:58:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74361, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72361 - Call ContentHandler::exportTransform in backupTextPass.inc and friends
Call ContentHandler::exportTransform in backupTextPass.inc and friends
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Export/Import (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=core p=8 s=2014-10-28
:
Depends on: 72417
Blocks: 72348
  Show dependency treegraph
 
Reported: 2014-10-22 15:48 UTC by Daniel Kinzler
Modified: 2014-10-29 08:58 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2014-10-22 15:48:57 UTC
ContentHandler::exportTransform needs to be called whenever serialized content is written to an (XML) dump. The WIkiExporter class used by SPecialExport and dumpBackup already does this, but backupTextPass.inc, which is used by the dump generation script on the live cluster, bypasses this.

Other maintenance scripts, like fetchText.php, should probably also apply exportTransform. Generally, all code that calls Revision::getRevisionText should be checked.
Comment 1 Gerrit Notification Bot 2014-10-23 12:53:50 UTC
Change 168126 had a related patch set uploaded by Daniel Kinzler:
Apply exportTarnsform in backupTextPass.inc

https://gerrit.wikimedia.org/r/168126
Comment 2 Gerrit Notification Bot 2014-10-23 13:12:03 UTC
Change 168126 had a related patch set uploaded by Daniel Kinzler:
Apply exportTarnsform in backupTextPass.inc

https://gerrit.wikimedia.org/r/168126
Comment 3 Daniel Kinzler 2014-10-23 14:15:11 UTC
Making this depend on bug 72417 following Hoo's comment on the patch.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links