Last modified: 2014-10-22 22:22:56 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74398, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 72398 - VisualEditor: Actually run tests for MWHeadingNode / MWPreformattedNode
VisualEditor: Actually run tests for MWHeadingNode / MWPreformattedNode
Status: ASSIGNED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: High enhancement
: VE-deploy-nextup
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-22 22:21 UTC by Roan Kattouw
Modified: 2014-10-22 22:22 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2014-10-22 22:21:08 UTC 
Right now we have a hack in ve.test.utils.js that reregisters the core versions of HeadingNode and PreformattedNode to ensure MWHeadingNode and MWPreformattedNode aren't used, because using them would break the VE core tests when run in VE-MW.

This is horrible, because it makes us unable to test specific behavior in the MW nodes. For instance, https://gerrit.wikimedia.org/r/#/c/162310/3 fails its own tests because those tests use HeadingNode rather than MWHeadingNode, even though the tests in question were clearly designed to use MWHeadingNode.

We should come up with a way that MW nodes can be not registered for code tests, but be registered for MW tests.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links