Last modified: 2014-11-12 23:20:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74405, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 72405 - VisualEditor Mobile: The label for "Re-use" tool is not greyed out when the tool is disabled (icon is greyed out)


Summary:	VisualEditor Mobile: The label for "Re-use" tool is not greyed out when the t...

Status:	VERIFIED FIXED

Product:	VisualEditor
Classification:	Unclassified
Component:	Mobile (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal
Target Milestone:	VE-deploy-2014-11-05 (1.25wmf7)
Assigned To:	Alex Monk

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-10-22 23:09 UTC by Rummana Yasmeen
Modified:	2014-11-12 23:20 UTC (History)
CC List:	8 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Screenshot (68.33 KB, image/png) 2014-10-22 23:09 UTC, Rummana Yasmeen	Details
Add an attachment (proposed patch, testcase, etc.)

Description Rummana Yasmeen 2014-10-22 23:09:57 UTC

Created attachment 16859 [details]
Screenshot

Steps to reproduce:

1.Open a page with mobile VE which does not have any reference in it to re-use.


Observed Result:

The "Re-use" label for the button is not greyed out even if the button icon is 

See the screenshot attached
Environment:Production,test2 and Betalabs

Comment 1 Alex Monk 2014-11-01 22:55:48 UTC

Looks like this is caused by MobileFrontend's less/modules/editor/VisualEditorOverlay.less file - specifically this part:
.oo-ui-tool-title {
    color: @grayDark;
    font-size: .9em;
}
Which is taking precedence over the styles for the oo-ui-widget-disabled stuff.

What if we changed it to this?
.oo-ui-widget-enabled > .oo-ui-tool-title {
    color: @grayDark;
}
.oo-ui-tool-title {
    font-size: .9em;
}

Comment 2 James Forrester 2014-11-03 16:14:32 UTC

(In reply to Alex Monk from comment #1)
> Looks like this is caused by MobileFrontend's
> less/modules/editor/VisualEditorOverlay.less file - specifically this part:
> .oo-ui-tool-title {
>     color: @grayDark;
>     font-size: .9em;
> }
> Which is taking precedence over the styles for the oo-ui-widget-disabled
> stuff.
> 
> What if we changed it to this?
> .oo-ui-widget-enabled > .oo-ui-tool-title {
>     color: @grayDark;
> }
> .oo-ui-tool-title {
>     font-size: .9em;
> }

Eurgh. Another reminder that we need to kill VisualEditorOverlay.less.

Comment 3 Gerrit Notification Bot 2014-11-03 20:39:40 UTC

Change 170790 had a related patch set uploaded by Alex Monk:
VE: Don't set @grayDark colour for tool titles in disabled widgets

https://gerrit.wikimedia.org/r/170790

Comment 4 Gerrit Notification Bot 2014-11-03 22:48:48 UTC

Change 170790 merged by jenkins-bot:
VE: Don't set @grayDark colour for tool titles in disabled widgets

https://gerrit.wikimedia.org/r/170790

Comment 5 Rummana Yasmeen 2014-11-04 00:07:59 UTC

Verified the fix in Betalabs

Comment 6 Rummana Yasmeen 2014-11-05 23:14:06 UTC

Verified the fix in test2

Comment 7 Rummana Yasmeen 2014-11-12 23:20:34 UTC

Verified the fix in production

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links