Last modified: 2014-11-03 13:34:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74417, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72417 - Put the <model> and <format> tags before the <text> tag in the XML dumps.
Put the <model> and <format> tags before the <text> tag in the XML dumps.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Export/Import (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
https://www.mediawiki.org/xml/export-...
:
Depends on:
Blocks: 72361
  Show dependency treegraph
 
Reported: 2014-10-23 09:02 UTC by Daniel Kinzler
Modified: 2014-11-03 13:34 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2014-10-23 09:02:40 UTC
According to export-0.9.xsd, the <model> and <format> tags follow the <text> tag. That is however quite annoying when processing the XML event stream, since it means we do not know how to process the contents of the <text> tag when we receive it. Adding <model> and <format> at the end was simply an oversight on my part when I introduced them.

Outputting these tags before the <text> tag would be simple to do, but would technically be a breaking change to the export format. I see no good way to make this backwards compatible, aside from outputting these tags twice.

As a stop gap, model and format could be included as attributes of the <text> tag. This is however rather inconsistent with the rest of the format, and would also need to be included in a new version of the XSD.
Comment 1 Daniel Kinzler 2014-10-23 09:04:13 UTC
Point in case: bug 72361 would be a lot easier to fix if model and format would appear before text in the xml event stream.
Comment 2 Nemo 2014-10-23 14:36:30 UTC
Do Special:Import and importDump.php care about the order of XML tags? I hope not, but they don't always behave logically. :)
Comment 3 Gerrit Notification Bot 2014-10-24 13:50:19 UTC
Change 168583 had a related patch set uploaded by Daniel Kinzler:
Move <model> and <format> tags in XML dumps.

https://gerrit.wikimedia.org/r/168583
Comment 4 wp mirror 2014-10-26 07:24:36 UTC
Would this also break `mwxml2sql'?
Comment 5 Gerrit Notification Bot 2014-10-31 17:28:33 UTC
Change 168583 merged by jenkins-bot:
Change position of <model> and <format> tags in XML dumps.

https://gerrit.wikimedia.org/r/168583

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links