Last modified: 2014-10-24 07:53:26 UTC
when viewing a (non-existent) page in the item namespace, with Wikibase Repo + Flow enabled together. [23-Oct-2014 18:40:32 UTC] PHP Catchable fatal error: Argument 1 passed to Flow\Content\Content::onShowMissingArticle() must be an instance of Article, instance of Wikibase\ViewItemAction given in /Library/WebServer/Documents/php-master/extensions/Flow/includes/Content/Content.php on line 25 [23-Oct-2014 18:40:32 UTC] PHP Stack trace: [23-Oct-2014 18:40:32 UTC] PHP 1. {main}() /Library/WebServer/Documents/php-master/index.php:0 [23-Oct-2014 18:40:32 UTC] PHP 2. MediaWiki->run() /Library/WebServer/Documents/php-master/index.php:46 [23-Oct-2014 18:40:32 UTC] PHP 3. MediaWiki->main() /Library/WebServer/Documents/php-master/includes/MediaWiki.php:435 [23-Oct-2014 18:40:32 UTC] PHP 4. MediaWiki->performRequest() /Library/WebServer/Documents/php-master/includes/MediaWiki.php:584 [23-Oct-2014 18:40:32 UTC] PHP 5. MediaWiki->performAction() /Library/WebServer/Documents/php-master/includes/MediaWiki.php:282[23-Oct-2014 18:40:32 UTC] PHP 6. Wikibase\ViewEntityAction->show() /Library/WebServer/Documents/php-master/includes/MediaWiki.php:414 [23-Oct-2014 18:40:32 UTC] PHP 7. Wikibase\ViewEntityAction->displayMissingEntity() /Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/actions/ViewEntityAction.php:124 [23-Oct-2014 18:40:32 UTC] PHP 8. wfRunHooks() /Library/WebServer/Documents/php-master/extensions/WikidataBuild/extensions/Wikibase/repo/includes/actions/ViewEntityAction.php:245 [23-Oct-2014 18:40:32 UTC] PHP 9. Hooks::run() /Library/WebServer/Documents/php-master/includes/GlobalFunctions.php:4021[23-Oct-2014 18:40:32 UTC] PHP 10. call_user_func_array:{/Library/WebServer/Documents/php-master/includes/Hooks.php:206}() /Library/WebServer/Documents/php-master/includes/Hooks.php:206 [23-Oct-2014 18:40:32 UTC] PHP 11. Flow\Content\Content::onShowMissingArticle() /Library/WebServer/Documents/php-master/includes/Hooks.php:206
At a minimum, it looks like https://www.mediawiki.org/wiki/Manual:Hooks/ShowMissingArticle needs to be updated to say that the first argument can be literlly anything, and not an article as implied(but not guaranteed)
Additionally, i'm not sure how i feel about passing a non-article through this hook. If this hook had been created yesterday instead of in 1.16 i'm almost certain it would have gotten the Article type hint.
Change 168383 had a related patch set uploaded by Aude: Provide Article object for ShowMissingArticle hook https://gerrit.wikimedia.org/r/168383
Change 168383 merged by jenkins-bot: Provide Article object for ShowMissingArticle hook https://gerrit.wikimedia.org/r/168383
