Last modified: 2014-10-29 18:25:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74468, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 72468 - VisualEditor: MWTitleInputWidget should return titles
VisualEditor: MWTitleInputWidget should return titles
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Technical Debt (Other open bugs)
unspecified
All All
: Normal normal
: VE-deploy-2014-11-05 (1.25wmf7)
Assigned To: Sucheta Ghoshal
:
Depends on: 71249
Blocks: 71998
  Show dependency tree / graph
 
Reported: 2014-10-24 01:41 UTC by Roan Kattouw
Modified: 2014-10-29 18:25 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2014-10-24 01:41:26 UTC 
MWTitleInputWidget should have a .getTitle() getter (which can return null, if the value isn't a valid title). Using this getter should be preferred over .getValue(). Callers of MWTitleInputWidget.getValue() should be converted to .getTitle(), and they should check for null-ness, because we probably have more bugs like bug 71998 hiding in various places.
Comment 1 Roan Kattouw 2014-10-24 02:24:26 UTC 
Also, per bug 71249, now that we have isValid() in TextInputWidget, it makes sense for MWTitleInputWidget to reimplement isValid() as a check for getTitle() not being null.
Comment 2 Gerrit Notification Bot 2014-10-28 22:16:42 UTC 
Change 169603 had a related patch set uploaded by SuchetaG:
Introducing getTitle() in MWTitleInputWidget

https://gerrit.wikimedia.org/r/169603
Comment 3 Gerrit Notification Bot 2014-10-29 18:14:08 UTC 
Change 169603 merged by jenkins-bot:
Introducing getTitle() in MWTitleInputWidget

https://gerrit.wikimedia.org/r/169603
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links