Last modified: 2014-10-29 08:16:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74471, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72471 - Using a generator together with a non-query module always uses new continue format
Using a generator together with a non-query module always uses new continue f...
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-24 09:18 UTC by Michael M.
Modified: 2014-10-29 08:16 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Michael M. 2014-10-24 09:18:13 UTC
When you use a generator together with a non-query module that can work on a list of pages (e.g. purge), the new continue format is always used, the parameter rawcontinue is unknown:

http://en.wikipedia.beta.wmflabs.org/w/api.php?action=purge&generator=allpages&gapfrom=A&gaplimit=2

http://en.wikipedia.beta.wmflabs.org/w/api.php?action=purge&generator=allpages&gapfrom=A&gaplimit=2&rawcontinue=1

Both add "continue" as continuation data, the second warns about the fact that rawcontinue is unknown.

As the continuation data was only added after the new continue format existed (bug 60734), I'm not sure whether this really is a bug, but at least it's not documented.
Comment 1 Brad Jorsch 2014-10-24 13:51:47 UTC
For all existing non-query modules that use ApiPageSet, there's no functional difference between the raw continuation and the simplified continuation so an option for raw continuation was never added.

It's not clear what documentation you're asking for here. "rawcontinue" is documented for action=query because it exists there, while it's not documented elsewhere because it doesn't exist elsewhere.
Comment 2 Umherirrender 2014-10-24 16:46:53 UTC
In generator mode there are never two continues(*), so there is no need for the "old" continue style.

(*)In my opinion there cannot be two or more continues, because there is no way to define a prop= which limit is exceeded and needs therefor its own continue (to complete the batch of titles from the generator module).
Comment 3 Michael M. 2014-10-25 08:03:26 UTC
(In reply to Brad Jorsch from comment #1)
> It's not clear what documentation you're asking for here. "rawcontinue" is
> documented for action=query because it exists there, while it's not
> documented elsewhere because it doesn't exist elsewhere.

"continue" is documented only for action=query, too. [[mw:API:Query#Continuing_queries]] says: "For backwards compatibility, clients must specify continue= in their initial queries to select this method.", which is true for action=query&generator=, but not for action=purge.

I don't think it's unreasonable to expect

http://en.wikipedia.beta.wmflabs.org/w/api.php?action=query&prop=info&generator=allpages&gapfrom=A&gaplimit=2

and

http://en.wikipedia.beta.wmflabs.org/w/api.php?action=purge&generator=allpages&gapfrom=A&gaplimit=2

to behave the same regarding continuation, and thus expecting a "query-continue" instead of "continue" for the action=purge request, too.

The current behavior is inconsistent, making it easily possible to miss the continuation for non-query modules. Only when the "continue" becomes default, it will be consistent again.
Comment 4 Brad Jorsch 2014-10-26 23:27:33 UTC
(In reply to Michael M. from comment #3)
> Only when the "continue" becomes default, it will be consistent again.

That's being worked on.
Comment 5 Brad Jorsch 2014-10-27 16:26:01 UTC
(In reply to Michael M. from comment #3)
> "continue" is documented only for action=query, too.

I see "continue" documented for action=purge, action=setnotificationtimestamp, and action=watch. https://en.wikipedia.org/w/api.php?modules=purge|setnotificationtimestamp|watch

Since the requested documentation is already present in the auto-generated help output and we're not going to add rawcontinue to these other modules, I'm going to WONTFIX this. If you're referring to the documentation on mediawiki.org, feel free to update that.
Comment 6 Michael M. 2014-10-29 08:16:37 UTC
(In reply to Brad Jorsch from comment #5)
> If you're referring to the documentation on
> mediawiki.org, feel free to update that.

I added [[mw:API:Query#Generators and continuation]]. Can you check that I didn't write anything wrong there?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links