Last modified: 2014-10-28 09:43:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74478, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 72478 - SHA1 checksum in XML dump is wrong for revisions that had an export transformation applied.
SHA1 checksum in XML dump is wrong for revisions that had an export transform...
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Export/Import (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 72348
  Show dependency tree / graph
 
Reported: 2014-10-24 14:05 UTC by Daniel Kinzler
Modified: 2014-10-28 09:43 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Daniel Kinzler 2014-10-24 14:05:02 UTC 
Currently, ContentHandler::exportTransform may modified page content on the fly when generating XML dumps. However, we are currently now re-calculating the SHA1 hash for the revision, causing it to be inconsistent with the transformed content.

The XML dump should contain sha1 checksums that are correct for the text in the dump, even if that differs from the raw contents of the database.
Comment 1 Gerrit Notification Bot 2014-10-24 14:08:30 UTC 
Change 168587 had a related patch set uploaded by Daniel Kinzler:
Re-caclulate SHA1 after applying exportTransform

https://gerrit.wikimedia.org/r/168587
Comment 2 Umherirrender 2014-10-24 14:36:22 UTC 
In my opinion the sha1 should be the same as in rev_sha1 and which is also outputted by the api. Maybe add a new hash as explicit checksum.
But sha in output should be the same as in the api.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links