Last modified: 2014-10-28 07:51:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74487, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72487 - Template-generated partial table cell markup incorrectly parsed (new - different - case)
Template-generated partial table cell markup incorrectly parsed (new - differ...
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Normal normal
: ---
Assigned To: ssastry
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-24 18:09 UTC by Kelson [Emmanuel Engelhart]
Modified: 2014-10-28 07:51 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kelson [Emmanuel Engelhart] 2014-10-24 18:09:25 UTC
Table CSS parameters are wrong parsed under certain circumstances. For example:
http://parsoid-lb.eqiad.wikimedia.org/idwiki/Nickelodeon_Kids%27_Choice_Awards?oldid=8237629

Comment about this from Subbu:
Kelson: your example is a bit different from the nlwiki scenario. Looks like we have an unhandled edge case. In the example below, the first row is handled, but the second isn't. Should be easy to fix.

{|
|-
!nowrap|Favorite Movie
| {{yes}}
|<!-- 1989 --> {{yes}}
|}

===

This bug is "similar" like #67850 bug and what reported their first:
https://bugzilla.wikimedia.org/show_bug.cgi?id=67850#c12

But the rootcause seems to be different (see following comment):
https://bugzilla.wikimedia.org/show_bug.cgi?id=67850#c13
Comment 1 Gerrit Notification Bot 2014-10-24 20:17:23 UTC
Change 168664 had a related patch set uploaded by Subramanya Sastry:
(Bug 72487) More robust handling of <td> split across page & template

https://gerrit.wikimedia.org/r/168664
Comment 2 ssastry 2014-10-24 21:17:58 UTC
Kelson, that fixes the page, but it also flagged a broken comment in one of the cells on the page .. php parser ignores it, but parsoid doesn't .. that is a wontfix on our end. you can edit the wikitext for that one cell and fix the comment.
Comment 3 Gerrit Notification Bot 2014-10-24 22:51:01 UTC
Change 168664 merged by jenkins-bot:
(Bug 72487) More robust handling of <td> split across page & template

https://gerrit.wikimedia.org/r/168664
Comment 4 Kelson [Emmanuel Engelhart] 2014-10-28 07:51:12 UTC
Works perfectly:
http://parsoid-lb.eqiad.wikimedia.org/idwiki/Nickelodeon_Kids%27_Choice_Awards?oldid=8244538

Thank you.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links