Last modified: 2014-10-27 19:07:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74506, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 72506 - QUnit failures in browser for toggling tests
QUnit failures in browser for toggling tests
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
Hygiene (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Jon
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-25 00:20 UTC by Jon
Modified: 2014-10-27 19:07 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2014-10-25 00:20:34 UTC 
http://127.0.0.1:8080/wiki/Special:JavaScriptTest/qunit?module=MobileFrontend%20toggle.js%3A%20remember%20expanded%20sections

causes various issues.
We should really be using sinon in some way here.

Side note:
* getExpandedSections has side effects (updates local storage)
* Really this code should be refactored. The toggle code is now horribly unreadable. We should think about giving it a complete rewrite, maybe making use of Page.
Comment 1 Bingle 2014-10-25 00:25:10 UTC 
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/bXRsm7AE
Comment 2 Gerrit Notification Bot 2014-10-27 18:18:18 UTC 
Change 169020 had a related patch set uploaded by Jdlrobson:
Fix failing tests

https://gerrit.wikimedia.org/r/169020
Comment 3 Gerrit Notification Bot 2014-10-27 18:21:12 UTC 
Change 169020 merged by Kaldari:
Fix failing tests

https://gerrit.wikimedia.org/r/169020
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links