Last modified: 2014-10-28 23:10:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74521, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 72521 - Edit preview doesn't work for JS and CSS pages (throws JS error)
Edit preview doesn't work for JS and CSS pages (throws JS error)
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized major
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-26 00:11 UTC by Ryan Kaldari
Modified: 2014-10-28 23:10 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ryan Kaldari 2014-10-26 00:11:44 UTC 
If you use the Wikitext editor to edit a JS or CSS page on mobile, it throws the following Javascript error: "resp.parse.sections[0] is undefined"

Apparently our previewing code assumes that the API always returns sections for pages (which JS and CSS pages don't have).
Comment 1 Bingle 2014-10-26 00:15:25 UTC 
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/sudMqbUn
Comment 2 Ryan Kaldari 2014-10-26 00:38:21 UTC 
Apparently this may be affecting regular pages as well.
Comment 3 Ryan Kaldari 2014-10-26 02:09:23 UTC 
Looks like there could be 2 separate bugs, as the preview on regular pages isn't throwing a JS error.
Comment 4 Gerrit Notification Bot 2014-10-26 13:07:03 UTC 
Change 168823 had a related patch set uploaded by Florianschmidtwelzow:
EditorApi: Check for sections

https://gerrit.wikimedia.org/r/168823
Comment 5 Gerrit Notification Bot 2014-10-28 22:36:34 UTC 
Change 168823 merged by jenkins-bot:
EditorApi: Check for sections

https://gerrit.wikimedia.org/r/168823
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links