Last modified: 2014-11-06 00:30:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74549, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72549 - $wgJobBackoffThrottling['gwtoolsetUploadMetadataJob'] is blown away later in CommonSettings.php
$wgJobBackoffThrottling['gwtoolsetUploadMetadataJob'] is blown away later in ...
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
wmf-deployment
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-27 08:01 UTC by Kevin Israel (PleaseStand)
Modified: 2014-11-06 00:30 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Kevin Israel (PleaseStand) 2014-10-27 08:01:38 UTC
Lines 1941-1943 of CommonSettings.php:

> // extra throttling until the image scalers are more robust
> GWToolset\Config::$mediafile_job_throttle_default = 5; // 5 files per batch
> $wgJobBackoffThrottling['gwtoolsetUploadMetadataJob'] = 5 / 3600; // 5 batches per hour

Lines 2390-2396 of CommonSettings.php:

> # Similar to above but not for single template/file changes
> $wgJobBackoffThrottling = array(
>    # Avoid excessive CPU due to cache misses from rapid invalidations
>    'htmlCacheUpdate' => 20, // pages/sec per runner
>    # Avoid excessive DB usage for backlink tables
>    'refreshLinks'    => 20, // pages/sec per runner
> );

The later assignment to $wgJobBackoffThrottling would prevent the assignment to $wgJobBackoffThrottling['gwtoolsetUploadMetadataJob'] from having any effect.

Either the earlier assignment is not needed and should be removed, or it is needed and the later assignment should be to individual keys and not the entire array. Which is the case?
Comment 1 Tisza Gergő 2014-10-27 22:42:22 UTC
I think we can get rid of the GWToolset throttling. It was mostly there to prevent the "fifty large TIFFs get thumbnailed at the same time when someone looks at Special:NewFiles" scenario, and since then thumbnail pre-rendering has been enabled (or will be real soon), so GWToolset should not contribute to that problem significantly.
Comment 2 Aaron Schulz 2014-11-06 00:30:42 UTC
This was fixed a while back.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links