Last modified: 2014-10-27 14:15:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74557, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72557 - MultimediaViewer pollutes user_properties with empty strings
MultimediaViewer pollutes user_properties with empty strings
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
MultimediaViewer (Other open bugs)
master
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-27 13:55 UTC by Tisza Gergő
Modified: 2014-10-27 14:15 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tisza Gergő 2014-10-27 13:55:02 UTC
mysql:research@s4-analytics-slave.eqiad.wmnet [commonswiki]> select up_value, count(*) from user_properties where up_property = 'multimediaviewer-enable' group by up_value;
+----------+----------+
| up_value | count(*) |
+----------+----------+
|          |        8 |
| 1        |      324 |
+----------+----------+
2 rows in set (0.65 sec)

The property is set via AJAX, and while there is already a fair amount of trickery in selecting the right value, it apparently still not works, and sets the value to an empty string on opt-out for wikis where opt-out is the default, when actually it should just delete the row.

The proper fix will probably involve setting  $wgDefaultUserOptions['multimediaviewer-enable'] to 1 instead of true.

An empty string and a missing row is handled the same way by the software, so this is a minor issue; at worst it might confuse stats scripts.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links