Last modified: 2014-10-29 21:47:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74587, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 72587 - OOUI PHP: Use <label> for LabelElement to make clicking on labels work without JavaScript
OOUI PHP: Use <label> for LabelElement to make clicking on labels work withou...
Status: RESOLVED FIXED
Product: OOjs UI
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High enhancement
: ---
Assigned To: Bartosz Dziewoński
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-27 21:18 UTC by Bartosz Dziewoński
Modified: 2014-10-29 21:47 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bartosz Dziewoński 2014-10-27 21:18:33 UTC
(Migrated from http://etherpad.wikimedia.org/p/OOUIPHP)

Use <label> for LabelElement to make clicking on labels work without JavaScript

* Where are you at with this? We really only have 2 options, generate
  arbitrary IDs (if no ID is set on the input) and use the for
  attribute on the label, or wrap the input with the label
** We probably can't change the HTML structure entirely everywhere…
   generating random IDs seems reasonable enough to me.
** Trevor says he wants to make FieldsetLayout a <label> with a
   LabelElement mixin <span> inside. That also sounds reasonable for
   the most common use case.
Comment 1 Gerrit Notification Bot 2014-10-27 21:20:42 UTC
Change 169218 had a related patch set uploaded by Bartosz Dziewoński:
Turn FieldLayout into a <label/>

https://gerrit.wikimedia.org/r/169218
Comment 2 Gerrit Notification Bot 2014-10-29 21:33:44 UTC
Change 169218 merged by jenkins-bot:
Turn FieldLayout into a <label/>

https://gerrit.wikimedia.org/r/169218

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links