Last modified: 2014-10-28 14:18:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74600, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 72600 - mediawiki_singlenode's $wgMainCacheType = CACHE_ACCEL can't be overridden


Summary:	mediawiki_singlenode's $wgMainCacheType = CACHE_ACCEL can't be overridden

Status:	PATCH_TO_REVIEW

Product:	Wikimedia Labs
Classification:	Unclassified
Component:	Infrastructure (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized major
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2014-10-28 00:34 UTC by spage
Modified:	2014-10-28 14:18 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description spage 2014-10-28 00:34:19 UTC

Puppet change Ia07c9f7c00960fecc0765c7c13e3897981c69600 added 
  # Cache where it's easy to
  $wgMainCacheType = CACHE_ACCEL;
to mediawiki_singlenode's LocalSettings.php template.  This line comes after
  require_once( 'orig/LocalSettings.php' );
so it can't be overridden.

But Flow invokes $cache->cas(), and CACHE_ACCEL (APCBagOStuff) doesn't implement it.  Our labs server ee-flow.eqiad.wmflabs already set $wgMainCacheType = CACHE_MEMCACHED in /srv/mediawiki/orig/LocalSettings.php , but this new puppet setting comes later and overrides it.

Can we move the wgMainCacheType line in labs-localsettings before pulling in orig/LocalSettings.php? Is there some reason the require_once() isn't near the end?

Comment 1 Gerrit Notification Bot 2014-10-28 00:53:16 UTC

Change 169288 had a related patch set uploaded by Spage:
Allow wgMainCacheType setting to be overridden

https://gerrit.wikimedia.org/r/169288

Comment 2 Gerrit Notification Bot 2014-10-28 14:18:10 UTC

Change 169288 merged by Andrew Bogott:
Allow wgMainCacheType setting to be overridden

https://gerrit.wikimedia.org/r/169288

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links