Last modified: 2014-10-29 22:10:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74634, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 72634 - Attempting to approve some OAuth consumers results in error
Attempting to approve some OAuth consumers results in error
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
OAuth (Other open bugs)
unspecified
All All
: High critical (vote)
: ---
Assigned To: Chris Steipp
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-28 17:44 UTC by Sage Ross
Modified: 2014-10-29 22:10 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sage Ross 2014-10-28 17:44:27 UTC 
Several OAuth admins report not being able to approve either of my latest proposed consumers: https://www.mediawiki.org/wiki/Special:OAuthListConsumers?name=&publisher=Ragesoss&stage=0

The error message they get is:
"Someone changed the attributes of this consumer as you viewed it. Please try again. You may want to check the change log."
Comment 1 Chris Steipp 2014-10-28 21:38:23 UTC 
Uhg, fatality of the updates to user tokens.

MWOAuthDAO::getChangeToken() relies on recalculating a hash that uses User::getEditToken().

The csrf token should be checked already, so for collision detection, we probably should just use the user id instead of their edit token.
Comment 2 Gerrit Notification Bot 2014-10-28 21:56:34 UTC 
Change 169593 had a related patch set uploaded by CSteipp:
Remove edit token from conflict detection

https://gerrit.wikimedia.org/r/169593
Comment 3 Gerrit Notification Bot 2014-10-29 17:00:26 UTC 
Change 169593 merged by jenkins-bot:
Remove edit token from conflict detection

https://gerrit.wikimedia.org/r/169593
Comment 4 Sage Ross 2014-10-29 21:19:40 UTC 
Now that the fix is merged and deployed, can someone approve my apps to see if it worked? :)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links