Last modified: 2014-11-05 04:45:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74671, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 72671 - ChangeOpClaim using obsolete Entity::setClaims causes stack trace when adding statement on Property page
ChangeOpClaim using obsolete Entity::setClaims causes stack trace when adding...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
master
All All
: High major (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=0
:
Depends on:
Blocks: 49554
  Show dependency tree / graph
 
Reported: 2014-10-29 11:56 UTC by Henning
Modified: 2014-11-05 04:45 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Henning 2014-10-29 11:56:16 UTC 
Causes stack trace when trying to set a statement via the UI on a Property page.


Fatal error: Call to undefined method Wikibase\DataModel\Entity\Property::setClaims() in C:\Program Files (x86)\Apache Software Foundation\Apache2.2\htdocs\mediawiki\core\extensions\Wikibase\repo\includes\ChangeOp\ChangeOpClaim.php on line 113

Call Stack:
    0.0010     366208   1. {main}() C:\Program Files (x86)\Apache Software Foundation\Apache2.2\htdocs\mediawiki\core\api.php:0
    0.2320   16288936   2. ApiMain->execute() C:\Program Files (x86)\Apache Software Foundation\Apache2.2\htdocs\mediawiki\core\api.php:85
    0.2320   16288968   3. ApiMain->executeActionWithErrorHandling() C:\Program Files (x86)\Apache Software Foundation\Apache2.2\htdocs\mediawiki\core\includes\api\ApiMain.php:358
    0.2320   16330416   4. ApiMain->executeAction() C:\Program Files (x86)\Apache Software Foundation\Apache2.2\htdocs\mediawiki\core\includes\api\ApiMain.php:387
    0.3580   23078008   5. Wikibase\Api\SetClaim->execute() C:\Program Files (x86)\Apache Software Foundation\Apache2.2\htdocs\mediawiki\core\includes\api\ApiMain.php:948
    0.3810   24554656   6. Wikibase\Api\ClaimModificationHelper->applyChangeOp() C:\Program Files (x86)\Apache Software Foundation\Apache2.2\htdocs\mediawiki\core\extensions\Wikibase\repo\includes\api\SetClaim.php:80
    0.6170   25377328   7. Wikibase\ChangeOp\ChangeOpClaim->apply() C:\Program Files (x86)\Apache Software Foundation\Apache2.2\htdocs\mediawiki\core\extensions\Wikibase\repo\includes\api\ClaimModificationHelper.php:205
Comment 1 Gerrit Notification Bot 2014-10-31 17:04:09 UTC 
Change 170342 had a related patch set uploaded by Aude:
Fix fatal error in ChangeOpClaim for properties

https://gerrit.wikimedia.org/r/170342
Comment 2 Gerrit Notification Bot 2014-11-02 13:40:01 UTC 
Change 170576 had a related patch set uploaded by Aude:
Fix for statements on properties in ChangeOpClaim

https://gerrit.wikimedia.org/r/170576
Comment 3 Aude 2014-11-02 13:44:21 UTC 
made a patch for ChangeOpClaim, though i suspect issues also exist in ChangeOpClaimRemove and perhaps elsewhere.
Comment 4 Gerrit Notification Bot 2014-11-04 19:39:34 UTC 
Change 170576 merged by jenkins-bot:
Fix for statements on properties in ChangeOpClaim

https://gerrit.wikimedia.org/r/170576
Comment 5 Aude 2014-11-05 04:45:58 UTC 
this particular issue is fixed, although it's probably not possible to remove statements on properties, etc.

see bug 72879 for issues in the other change ops classes.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links